From: Matthew Wilcox <willy@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: manualinux@yahoo.es,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ntfs3: provide block_invalidate_folio to fix memory leak
Date: Mon, 30 May 2022 14:53:23 +0100 [thread overview]
Message-ID: <YpTMU0zutHgxPI45@casper.infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.02.2205300830220.28067@file01.intranet.prod.int.rdu2.redhat.com>
On Mon, May 30, 2022 at 08:57:15AM -0400, Mikulas Patocka wrote:
> In the kernel 5.17 and before, if the "invalidatepage" method is NULL, the
> kernel will use block_invalidatepage (see do_invalidatepage). So, we don't
> have to provide explicit "invalidatepage" in 5.17 and before and we don't
> have to backport this bugfix there.
>
> Note that the commit 7ba13abbd31e contains this piece of code:
> -#ifdef CONFIG_BLOCK
> - if (!invalidatepage)
> - invalidatepage = block_invalidatepage;
> -#endif
>
> So, it explicitly breaks filesystems that have NULL invalidatepage and
> NULL invalidate_folio and that relied on block_invalidatepage being called
> implicitly. So, I believe this commit is the root cause of this bug.
Oh, right, I missed ntfs3 in that commit. Oops.
Acked-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2022-05-30 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220524075112.5438df32.ref@yahoo.es>
[not found] ` <20220524075112.5438df32@yahoo.es>
[not found] ` <alpine.LRH.2.02.2205240501130.17784@file01.intranet.prod.int.rdu2.redhat.com>
[not found] ` <20220524113314.71fe17f0@yahoo.es>
[not found] ` <20220525130538.38fd3d35@yahoo.es>
[not found] ` <20220527072629.332b078d@yahoo.es>
[not found] ` <20220527080211.15d631be@yahoo.es>
[not found] ` <alpine.LRH.2.02.2205271338250.20527@file01.intranet.prod.int.rdu2.redhat.com>
[not found] ` <20220528061836.22230f86@yahoo.es>
[not found] ` <20220530131524.7fb5640d@yahoo.es>
2022-05-30 12:00 ` [PATCH] ntfs3: provide block_invalidate_folio to fix memory leak Mikulas Patocka
2022-05-30 12:18 ` Matthew Wilcox
2022-05-30 12:57 ` Mikulas Patocka
2022-05-30 13:53 ` Matthew Wilcox [this message]
2022-05-30 14:00 ` Namjae Jeon
2022-06-01 10:35 ` Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpTMU0zutHgxPI45@casper.infradead.org \
--to=willy@infradead.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=manualinux@yahoo.es \
--cc=mpatocka@redhat.com \
--cc=ntfs3@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).