From: Matthew Wilcox <willy@infradead.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org
Subject: Re: [viro-vfs:work.iov_iter_get_pages 24/33] lib/iov_iter.c:1295 iter_xarray_get_pages() warn: unsigned 'count' is never less than zero.
Date: Sun, 19 Jun 2022 16:54:57 +0100 [thread overview]
Message-ID: <Yq9G0ROCWfCg+Don@casper.infradead.org> (raw)
In-Reply-To: <Yq9FZnyna9BiwzDK@ZenIV>
On Sun, Jun 19, 2022 at 04:48:54PM +0100, Al Viro wrote:
> On Sun, Jun 19, 2022 at 11:40:37PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.iov_iter_get_pages
> > head: fe8e2809c7db0ec65403b31b50906f3f481a9b10
> > commit: e64d637d648390e4ac0643747ae174c3be15f243 [24/33] iov_iter: saner helper for page array allocation
> > config: mips-randconfig-m031-20220619 (https://download.01.org/0day-ci/archive/20220619/202206192306.POJg04ej-lkp@intel.com/config)
> > compiler: mips-linux-gcc (GCC) 11.3.0
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > smatch warnings:
> > lib/iov_iter.c:1295 iter_xarray_get_pages() warn: unsigned 'count' is never less than zero.
>
> Joy... Should've been int all along, obviously (pgoff_t for number of array
> elements?)
I've been using 'long' for that just because I don't want the drama of
"we need to support 16GB pages" to have anything to do with me.
next prev parent reply other threads:[~2022-06-19 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 15:40 [viro-vfs:work.iov_iter_get_pages 24/33] lib/iov_iter.c:1295 iter_xarray_get_pages() warn: unsigned 'count' is never less than zero kernel test robot
2022-06-19 15:48 ` Al Viro
2022-06-19 15:54 ` Matthew Wilcox [this message]
2022-06-19 16:19 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yq9G0ROCWfCg+Don@casper.infradead.org \
--to=willy@infradead.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox