From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
Minchan Kim <minchan@kernel.org>
Cc: open list <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
regressions@lists.linux.dev, Jens Axboe <axboe@kernel.dk>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: qemu-arm: zram: mkfs.ext4 : Unable to handle kernel NULL pointer dereference at virtual address 00000140
Date: Wed, 8 Jun 2022 16:36:05 +0900 [thread overview]
Message-ID: <YqBRZcsfrRMZXMCC@google.com> (raw)
In-Reply-To: <YqANP1K/6oRNCUKZ@google.com>
On (22/06/08 11:45), Sergey Senozhatsky wrote:
>
> Something like this?
May be even something like below. Move static initializer to cpu up
hook.
---
mm/zsmalloc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9152fbde33b5..6d3789d834e2 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -453,9 +453,7 @@ MODULE_ALIAS("zpool-zsmalloc");
#endif /* CONFIG_ZPOOL */
/* per-cpu VM mapping areas for zspage accesses that cross page boundaries */
-static DEFINE_PER_CPU(struct mapping_area, zs_map_area) = {
- .lock = INIT_LOCAL_LOCK(lock),
-};
+static DEFINE_PER_CPU(struct mapping_area, zs_map_area);
static __maybe_unused int is_first_page(struct page *page)
{
@@ -1113,6 +1111,7 @@ static inline int __zs_cpu_up(struct mapping_area *area)
area->vm_buf = kmalloc(ZS_MAX_ALLOC_SIZE, GFP_KERNEL);
if (!area->vm_buf)
return -ENOMEM;
+ local_lock_init(&area->lock);
return 0;
}
--
2.36.1.255.ge46751e96f-goog
next prev parent reply other threads:[~2022-06-08 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 8:49 qemu-arm: zram: mkfs.ext4 : Unable to handle kernel NULL pointer dereference at virtual address 00000140 Naresh Kamboju
2022-06-06 17:36 ` Minchan Kim
2022-06-07 1:21 ` Naresh Kamboju
2022-06-07 23:52 ` Minchan Kim
2022-06-08 2:39 ` Sergey Senozhatsky
2022-06-08 2:42 ` Sergey Senozhatsky
2022-06-08 2:45 ` Sergey Senozhatsky
2022-06-08 7:36 ` Sergey Senozhatsky [this message]
2022-06-12 15:26 ` Naresh Kamboju
2022-06-13 7:54 ` Sergey Senozhatsky
2022-06-13 16:49 ` Minchan Kim
2022-06-14 3:19 ` Sergey Senozhatsky
2022-06-15 16:47 ` Minchan Kim
2022-06-08 20:45 ` Minchan Kim
2022-06-09 11:02 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqBRZcsfrRMZXMCC@google.com \
--to=senozhatsky@chromium.org \
--cc=axboe@kernel.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=ngupta@vflare.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).