linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Deming Wang <wangdeming@inspur.com>
Cc: stefanha@redhat.com, miklos@szeredi.hu,
	virtualization@lists.linux-foundation.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs
Date: Wed, 15 Jun 2022 13:57:19 -0400	[thread overview]
Message-ID: <YqodfwS3KSVIaqKD@redhat.com> (raw)
In-Reply-To: <20220610020838.1543-1-wangdeming@inspur.com>

On Thu, Jun 09, 2022 at 10:08:38PM -0400, Deming Wang wrote:
> fs parameter not used. So, it needs to be deleted.
> 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>

Thanks Deming Wang for the patch. Good cleanup.

Reviewed-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

> ---
>  fs/fuse/virtio_fs.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 8db53fa67359..0991199d19c1 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -741,8 +741,7 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,
>  }
>  
>  /* Free virtqueues (device must already be reset) */
> -static void virtio_fs_cleanup_vqs(struct virtio_device *vdev,
> -				  struct virtio_fs *fs)
> +static void virtio_fs_cleanup_vqs(struct virtio_device *vdev)
>  {
>  	vdev->config->del_vqs(vdev);
>  }
> @@ -895,7 +894,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
>  
>  out_vqs:
>  	virtio_reset_device(vdev);
> -	virtio_fs_cleanup_vqs(vdev, fs);
> +	virtio_fs_cleanup_vqs(vdev);
>  	kfree(fs->vqs);
>  
>  out:
> @@ -927,7 +926,7 @@ static void virtio_fs_remove(struct virtio_device *vdev)
>  	virtio_fs_stop_all_queues(fs);
>  	virtio_fs_drain_all_queues_locked(fs);
>  	virtio_reset_device(vdev);
> -	virtio_fs_cleanup_vqs(vdev, fs);
> +	virtio_fs_cleanup_vqs(vdev);
>  
>  	vdev->priv = NULL;
>  	/* Put device reference on virtio_fs object */
> -- 
> 2.27.0
> 


  parent reply	other threads:[~2022-06-15 17:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  2:08 [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs Deming Wang
2022-06-15 13:54 ` Stefan Hajnoczi
2022-06-15 17:57 ` Vivek Goyal [this message]
2022-07-18 14:02 ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqodfwS3KSVIaqKD@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wangdeming@inspur.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).