From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Matthew Wilcox <willy@infradead.org>,
David Howells <dhowells@redhat.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Brauner <brauner@kernel.org>,
Keith Busch <kbusch@kernel.org>
Subject: [block.git conflicts] Re: [PATCH 37/44] block: convert to advancing variants of iov_iter_get_pages{,_alloc}()
Date: Thu, 30 Jun 2022 23:11:27 +0100 [thread overview]
Message-ID: <Yr4fj0uGfjX5ZvDI@ZenIV> (raw)
In-Reply-To: <20220622041552.737754-37-viro@zeniv.linux.org.uk>
On Wed, Jun 22, 2022 at 05:15:45AM +0100, Al Viro wrote:
> ... doing revert if we end up not using some pages
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
... and the first half of that thing conflicts with "block: relax direct
io memory alignment" in -next...
Joy. It's not hard to redo on top of the commit in there; the
question is, how to deal with conflicts?
I can do a backmerge, provided that there's a sane tag or branch to
backmerge from. Another fun (if trivial) issue in the same series
is around "iov: introduce iov_iter_aligned" (two commits prior).
Jens, Keith, do you have any suggestions? AFAICS, variants include
* tag or branch covering b1a000d3b8ec582da64bb644be633e5a0beffcbf
(I'd rather not grab the entire for-5.20/block for obvious reasons)
It sits in the beginning of for-5.20/block, so that should be fairly
straightforward, provided that you are not going to do rebases there.
If you are, could you put that stuff into an invariant branch, so
I'd just pull it?
* feeding the entire iov_iter pile through block.git;
bad idea, IMO, seeing that it contains a lot of stuff far from
anything block-related.
* doing a manual conflict resolution on top of my branch
and pushing that out. Would get rid of the problem from -next, but
Linus hates that kind of stuff, AFAIK, and with good reasons.
I would prefer the first variant (and that's what I'm
going to do locally for now - just
git tag keith_stuff bf8d08532bc19a14cfb54ae61099dccadefca446
and backmerge from it), but if you would prefer to deal with that
differently - please tell.
next prev parent reply other threads:[~2022-06-30 22:11 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 4:10 [RFC][CFT][PATCHSET] iov_iter stuff Al Viro
2022-06-22 4:15 ` [PATCH 01/44] 9p: handling Rerror without copy_from_iter_full() Al Viro
2022-06-22 4:15 ` [PATCH 02/44] No need of likely/unlikely on calls of check_copy_size() Al Viro
2022-06-22 4:15 ` [PATCH 03/44] teach iomap_dio_rw() to suppress dsync Al Viro
2022-06-22 4:15 ` [PATCH 04/44] btrfs: use IOMAP_DIO_NOSYNC Al Viro
2022-06-22 4:15 ` [PATCH 05/44] struct file: use anonymous union member for rcuhead and llist Al Viro
2022-06-22 4:15 ` [PATCH 06/44] iocb: delay evaluation of IS_SYNC(...) until we want to check IOCB_DSYNC Al Viro
2022-06-22 4:15 ` [PATCH 07/44] keep iocb_flags() result cached in struct file Al Viro
2022-06-22 4:15 ` [PATCH 08/44] copy_page_{to,from}_iter(): switch iovec variants to generic Al Viro
2022-06-27 18:31 ` Jeff Layton
2022-06-28 12:32 ` Christian Brauner
2022-06-28 18:36 ` Al Viro
2022-06-22 4:15 ` [PATCH 09/44] new iov_iter flavour - ITER_UBUF Al Viro
2022-06-27 18:47 ` Jeff Layton
2022-06-28 18:41 ` Al Viro
2022-06-28 12:38 ` Christian Brauner
2022-06-28 18:44 ` Al Viro
2022-07-28 9:55 ` [PATCH 9/44] " Alexander Gordeev
2022-07-29 17:21 ` Al Viro
2022-07-29 21:12 ` Alexander Gordeev
2022-07-30 0:03 ` Al Viro
2022-06-22 4:15 ` [PATCH 10/44] switch new_sync_{read,write}() to ITER_UBUF Al Viro
2022-06-22 4:15 ` [PATCH 11/44] iov_iter_bvec_advance(): don't bother with bvec_iter Al Viro
2022-06-27 18:48 ` Jeff Layton
2022-06-28 12:40 ` Christian Brauner
2022-06-22 4:15 ` [PATCH 12/44] fix short copy handling in copy_mc_pipe_to_iter() Al Viro
2022-06-27 19:15 ` Jeff Layton
2022-06-28 12:42 ` Christian Brauner
2022-06-22 4:15 ` [PATCH 13/44] splice: stop abusing iov_iter_advance() to flush a pipe Al Viro
2022-06-27 19:17 ` Jeff Layton
2022-06-28 12:43 ` Christian Brauner
2022-06-22 4:15 ` [PATCH 14/44] ITER_PIPE: helper for getting pipe buffer by index Al Viro
2022-06-28 10:38 ` Jeff Layton
2022-06-28 12:45 ` Christian Brauner
2022-06-22 4:15 ` [PATCH 15/44] ITER_PIPE: helpers for adding pipe buffers Al Viro
2022-06-28 11:32 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 16/44] ITER_PIPE: allocate buffers as we go in copy-to-pipe primitives Al Viro
2022-06-22 4:15 ` [PATCH 17/44] ITER_PIPE: fold push_pipe() into __pipe_get_pages() Al Viro
2022-06-22 4:15 ` [PATCH 18/44] ITER_PIPE: lose iter_head argument of __pipe_get_pages() Al Viro
2022-06-22 4:15 ` [PATCH 19/44] ITER_PIPE: clean pipe_advance() up Al Viro
2022-06-22 4:15 ` [PATCH 20/44] ITER_PIPE: clean iov_iter_revert() Al Viro
2022-06-22 4:15 ` [PATCH 21/44] ITER_PIPE: cache the type of last buffer Al Viro
2022-06-22 4:15 ` [PATCH 22/44] ITER_PIPE: fold data_start() and pipe_space_for_user() together Al Viro
2022-06-22 4:15 ` [PATCH 23/44] iov_iter_get_pages{,_alloc}(): cap the maxsize with MAX_RW_COUNT Al Viro
2022-06-28 11:41 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 24/44] iov_iter_get_pages_alloc(): lift freeing pages array on failure exits into wrapper Al Viro
2022-06-28 11:45 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 25/44] iov_iter_get_pages(): sanity-check arguments Al Viro
2022-06-28 11:47 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 26/44] unify pipe_get_pages() and pipe_get_pages_alloc() Al Viro
2022-06-28 11:49 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 27/44] unify xarray_get_pages() and xarray_get_pages_alloc() Al Viro
2022-06-28 11:50 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 28/44] unify the rest of iov_iter_get_pages()/iov_iter_get_pages_alloc() guts Al Viro
2022-06-28 11:54 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 29/44] ITER_XARRAY: don't open-code DIV_ROUND_UP() Al Viro
2022-06-28 11:54 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 30/44] iov_iter: lift dealing with maxpages out of first_{iovec,bvec}_segment() Al Viro
2022-06-28 11:56 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 31/44] iov_iter: first_{iovec,bvec}_segment() - simplify a bit Al Viro
2022-06-28 11:58 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 32/44] iov_iter: massage calling conventions for first_{iovec,bvec}_segment() Al Viro
2022-06-28 12:06 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 33/44] found_iovec_segment(): just return address Al Viro
2022-06-28 12:09 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 34/44] fold __pipe_get_pages() into pipe_get_pages() Al Viro
2022-06-28 12:11 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 35/44] iov_iter: saner helper for page array allocation Al Viro
2022-06-28 12:12 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 36/44] iov_iter: advancing variants of iov_iter_get_pages{,_alloc}() Al Viro
2022-06-28 12:13 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 37/44] block: convert to " Al Viro
2022-06-28 12:16 ` Jeff Layton
2022-06-30 22:11 ` Al Viro [this message]
2022-06-30 22:39 ` [block.git conflicts] " Al Viro
2022-07-01 2:07 ` Keith Busch
2022-07-01 17:40 ` Al Viro
2022-07-01 17:53 ` Keith Busch
2022-07-01 18:07 ` Al Viro
2022-07-01 18:12 ` Al Viro
2022-07-01 18:38 ` Keith Busch
2022-07-01 19:08 ` Al Viro
2022-07-01 19:28 ` Keith Busch
2022-07-01 19:43 ` Al Viro
2022-07-01 19:56 ` Keith Busch
2022-07-02 5:35 ` Al Viro
2022-07-02 21:02 ` Keith Busch
2022-07-01 19:05 ` Keith Busch
2022-07-01 21:30 ` Jens Axboe
2022-06-30 23:07 ` Jens Axboe
2022-07-10 18:04 ` Sedat Dilek
2022-06-22 4:15 ` [PATCH 38/44] iter_to_pipe(): switch to advancing variant of iov_iter_get_pages() Al Viro
2022-06-28 12:18 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 39/44] af_alg_make_sg(): " Al Viro
2022-06-28 12:18 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 40/44] 9p: convert to advancing variant of iov_iter_get_pages_alloc() Al Viro
2022-07-01 9:01 ` Dominique Martinet
2022-07-01 13:47 ` Christian Schoenebeck
2022-07-06 22:06 ` Christian Schoenebeck
2022-06-22 4:15 ` [PATCH 41/44] ceph: switch the last caller " Al Viro
2022-06-28 12:20 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 42/44] get rid of non-advancing variants Al Viro
2022-06-28 12:21 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 43/44] pipe_get_pages(): switch to append_pipe() Al Viro
2022-06-28 12:23 ` Jeff Layton
2022-06-22 4:15 ` [PATCH 44/44] expand those iov_iter_advance() Al Viro
2022-06-28 12:23 ` Jeff Layton
2022-07-01 6:21 ` [PATCH 01/44] 9p: handling Rerror without copy_from_iter_full() Dominique Martinet
2022-07-01 6:25 ` Dominique Martinet
2022-07-01 16:02 ` Christian Schoenebeck
2022-07-01 21:00 ` Dominique Martinet
2022-07-03 13:30 ` Christian Schoenebeck
2022-08-01 12:42 ` [PATCH 09/44] new iov_iter flavour - ITER_UBUF David Howells
2022-08-01 21:14 ` Al Viro
2022-08-01 22:54 ` David Howells
2022-06-23 15:21 ` [RFC][CFT][PATCHSET] iov_iter stuff David Howells
2022-06-23 20:32 ` Al Viro
2022-06-28 12:25 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr4fj0uGfjX5ZvDI@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).