From: Al Viro <viro@zeniv.linux.org.uk>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/6] fs: clear FMODE_LSEEK if no llseek function
Date: Fri, 24 Jun 2022 18:04:19 +0100 [thread overview]
Message-ID: <YrXuk+zOt4xFRDMI@ZenIV> (raw)
In-Reply-To: <20220624165631.2124632-4-Jason@zx2c4.com>
On Fri, Jun 24, 2022 at 06:56:28PM +0200, Jason A. Donenfeld wrote:
> This helps unify a longstanding wart where FMODE_LSEEK hasn't been
> uniformly unset when it should be.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> fs/file_table.c | 2 ++
> fs/open.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 5424e3a8df5f..15700b2e1b53 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -241,6 +241,8 @@ static struct file *alloc_file(const struct path *path, int flags,
> if ((file->f_mode & FMODE_WRITE) &&
> likely(fop->write || fop->write_iter))
> file->f_mode |= FMODE_CAN_WRITE;
> + if ((file->f_mode & FMODE_LSEEK) && !file->f_op->llseek)
> + file->f_mode &= ~FMODE_LSEEK;
Where would FMODE_LSEEK come from in this one? ->f_mode is set
(in __alloc_file()) to OPEN_FMODE(flags); that does deal with FMODE_READ
and FMODE_WRITE, but FMODE_LSEEK will be clear...
next prev parent reply other threads:[~2022-06-24 17:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 16:56 [PATCH 0/6] cleanup llseek and splice Jason A. Donenfeld
2022-06-24 16:56 ` [PATCH 1/6] ksmbd: use vfs_llseek instead of dereferencing NULL Jason A. Donenfeld
2022-06-24 21:20 ` Al Viro
2022-06-25 4:10 ` Namjae Jeon
2022-06-24 16:56 ` [PATCH 2/6] fs: do not set no_llseek in fops Jason A. Donenfeld
2022-06-24 21:48 ` Al Viro
2022-06-25 10:46 ` Jason A. Donenfeld
2022-06-24 16:56 ` [PATCH 3/6] fs: clear FMODE_LSEEK if no llseek function Jason A. Donenfeld
2022-06-24 17:04 ` Al Viro [this message]
2022-06-24 17:09 ` Jason A. Donenfeld
2022-06-24 17:13 ` Al Viro
2022-06-24 17:17 ` Jason A. Donenfeld
2022-06-24 16:56 ` [PATCH 4/6] fs: check FMODE_LSEEK to control internal pipe splicing Jason A. Donenfeld
2022-06-24 16:56 ` [PATCH 5/6] dma-buf: remove useless FMODE_LSEEK flag Jason A. Donenfeld
2022-06-24 21:51 ` Al Viro
2022-06-24 16:56 ` [PATCH 6/6] vfio: do not set " Jason A. Donenfeld
2022-06-24 21:53 ` Al Viro
2022-06-25 10:52 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXuk+zOt4xFRDMI@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Jason@zx2c4.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).