From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF5AC433EF for ; Fri, 24 Jun 2022 17:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231786AbiFXRNf (ORCPT ); Fri, 24 Jun 2022 13:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229969AbiFXRNe (ORCPT ); Fri, 24 Jun 2022 13:13:34 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 902B3532D0; Fri, 24 Jun 2022 10:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hGizkXyCuVX5aMeSolfPSxkd4CJ1ThVTLYB0JBt1uJM=; b=LFvTRfsXcgENF8F4LOb0XNdnZt 1WnCc+Aj23YjsMItFta6kuhs3oZnUYzb83eTvbw3tGi1wJ9GQLKzRBSrgD+0ANf5cebyjDGAPn/n1 KuhW2dUz207pyITH7GrzlQpZJjCVSr7DL2PMRopAJcPaH3B1136hUnDCBmxwKsERoujVBM0PesosR WKzS81L902w+ebIAZ4EXrmatAcTQsxbGRXmtW18Yai1SOguU/4rody26bPGOU+787zNxAMtOBEIJe 7Itg9hoBYO379McBL/h2R/sLDO+4CL533U3NsJnMtg7T/c07Vmr02Bh0bdEoP/gCEv+sS7FEZYilX Snrwol9g==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.95 #2 (Red Hat Linux)) id 1o4ms5-0040bm-DK; Fri, 24 Jun 2022 17:13:29 +0000 Date: Fri, 24 Jun 2022 18:13:29 +0100 From: Al Viro To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/6] fs: clear FMODE_LSEEK if no llseek function Message-ID: References: <20220624165631.2124632-1-Jason@zx2c4.com> <20220624165631.2124632-4-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jun 24, 2022 at 07:09:17PM +0200, Jason A. Donenfeld wrote: > Hi Al, > > On Fri, Jun 24, 2022 at 06:04:19PM +0100, Al Viro wrote: > > On Fri, Jun 24, 2022 at 06:56:28PM +0200, Jason A. Donenfeld wrote: > > > This helps unify a longstanding wart where FMODE_LSEEK hasn't been > > > uniformly unset when it should be. > > > > > > Signed-off-by: Jason A. Donenfeld > > > --- > > > fs/file_table.c | 2 ++ > > > fs/open.c | 2 ++ > > > 2 files changed, 4 insertions(+) > > > > > > diff --git a/fs/file_table.c b/fs/file_table.c > > > index 5424e3a8df5f..15700b2e1b53 100644 > > > --- a/fs/file_table.c > > > +++ b/fs/file_table.c > > > @@ -241,6 +241,8 @@ static struct file *alloc_file(const struct path *path, int flags, > > > if ((file->f_mode & FMODE_WRITE) && > > > likely(fop->write || fop->write_iter)) > > > file->f_mode |= FMODE_CAN_WRITE; > > > + if ((file->f_mode & FMODE_LSEEK) && !file->f_op->llseek) > > > + file->f_mode &= ~FMODE_LSEEK; > > > > Where would FMODE_LSEEK come from in this one? ->f_mode is set > > (in __alloc_file()) to OPEN_FMODE(flags); that does deal with FMODE_READ > > and FMODE_WRITE, but FMODE_LSEEK will be clear... > > >From the `int flags` parameter of the function. That's an O flag not an > F flag, though, so I assume you mean that it's impossible to get LSEEK > there in practice? If so, I'll drop this hunk. if (file->f_op->llseek) file->f_mode |= FMODE_LSEEK; you want it to match what came in file_operations...