From: Matthew Wilcox <willy@infradead.org>
To: Xin Gao <gaoxin@cdjrlc.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hfsplus: Fix code typo
Date: Fri, 22 Jul 2022 22:32:56 +0100 [thread overview]
Message-ID: <YtsXiPPmQ5cqVsqp@casper.infradead.org> (raw)
In-Reply-To: <20220722195133.18730-1-gaoxin@cdjrlc.com>
On Sat, Jul 23, 2022 at 03:51:33AM +0800, Xin Gao wrote:
> The double `free' is duplicated in line 498, remove one.
This is wrong. The intended meaning here is "trying to free bnode
which is already free". Please don't send patches for code you don't
understand.
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> fs/hfsplus/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c
> index 66774f4cb4fd..655cf60eabbf 100644
> --- a/fs/hfsplus/btree.c
> +++ b/fs/hfsplus/btree.c
> @@ -495,7 +495,7 @@ void hfs_bmap_free(struct hfs_bnode *node)
> m = 1 << (~nidx & 7);
> byte = data[off];
> if (!(byte & m)) {
> - pr_crit("trying to free free bnode "
> + pr_crit("trying to free bnode "
> "%u(%d)\n",
> node->this, node->type);
> kunmap(page);
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-07-22 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 19:51 [PATCH] hfsplus: Fix code typo Xin Gao
2022-07-22 20:12 ` James Bottomley
2022-07-22 21:32 ` Matthew Wilcox [this message]
2022-07-24 10:48 ` Harald Arnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtsXiPPmQ5cqVsqp@casper.infradead.org \
--to=willy@infradead.org \
--cc=gaoxin@cdjrlc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).