From: Matthew Wilcox <willy@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Viacheslav Dubeyko <slava@dubeyko.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hfsplus: Convert kmap() to kmap_local_page() in bitmap.c
Date: Tue, 26 Jul 2022 21:38:01 +0100 [thread overview]
Message-ID: <YuBQqe345DR2hBsa@casper.infradead.org> (raw)
In-Reply-To: <YuA8dgXPoDklBryE@iweiny-desk3>
On Tue, Jul 26, 2022 at 12:11:50PM -0700, Ira Weiny wrote:
> On Mon, Jul 25, 2022 at 06:54:50PM +0100, Matthew Wilcox wrote:
> > On Mon, Jul 25, 2022 at 10:17:13AM -0700, Viacheslav Dubeyko wrote:
> > > Looks good. Maybe, it makes sense to combine all kmap() related modifications in HFS+ into
> > > one patchset?
> >
> > For bisection, I'd think it best to leave them separate?
>
> I'm not quite sure I understand why putting the individual patches into a
> series makes bisection easier? It does make sense to keep individual patches.
If somebody reports a bug, bisection will tell you which of these
kmap-conversion patches is at fault, reducing the amount of brainpower
you have to invest in determining where the bug is.
next prev parent reply other threads:[~2022-07-26 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 20:50 [PATCH] hfsplus: Convert kmap() to kmap_local_page() in bitmap.c Fabio M. De Francesco
2022-07-25 17:17 ` Viacheslav Dubeyko
2022-07-25 17:54 ` Matthew Wilcox
2022-07-26 18:40 ` Viacheslav Dubeyko
2022-08-01 12:56 ` Fabio M. De Francesco
2022-07-26 19:11 ` Ira Weiny
2022-07-26 20:38 ` Matthew Wilcox [this message]
2022-07-26 12:04 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuBQqe345DR2hBsa@casper.infradead.org \
--to=willy@infradead.org \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).