From: Al Viro <viro@zeniv.linux.org.uk>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-fsdevel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/4 v2] fs/dcache: Resolve the last RT woes.
Date: Sat, 30 Jul 2022 05:41:25 +0100 [thread overview]
Message-ID: <YuS2dYPtfed+lHji@ZenIV> (raw)
In-Reply-To: <20220727114904.130761-1-bigeasy@linutronix.de>
On Wed, Jul 27, 2022 at 01:49:00PM +0200, Sebastian Andrzej Siewior wrote:
> This is v2 of the series, v1 is available at
> https://https://lkml.kernel.org/r/.kernel.org/all/20220613140712.77932-1-bigeasy@linutronix.de/
>
> v1…v2:
> - Make patch around Al's description of a bug in d_add_ci(). I took
> the liberty to make him Author and added his signed-off-by since I
> sinmply added a patch-body around his words.
>
> - The reasoning of why delaying the wakeup is reasonable has been
> replaced with Al's analysis of the code.
>
> - The split of wake up has been done differently (and I hope this is
> what Al meant). First the wake up has been pushed to the caller and
> then delayed to end_dir_add() after preemption has been enabled.
>
> - There is still __d_lookup_unhash(), __d_lookup_unhash_wake() and
> __d_lookup_done() is removed.
> __d_lookup_done() is removed because it is exported and the return
> value changes which will affect OOT users which are not aware of
> it.
> There is still d_lookup_done() which invokes
> __d_lookup_unhash_wake(). This can't remain in the header file due
> to cyclic depencies which in turn can't resolve wake_up_all()
> within the inline function.
Applied, with slightly different first commit (we only care about
d_lookup_done() if d_splice_alias() returns non-NULL).
See vfs.git#work.dcache.
prev parent reply other threads:[~2022-07-30 4:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 11:49 [PATCH 0/4 v2] fs/dcache: Resolve the last RT woes Sebastian Andrzej Siewior
2022-07-27 11:49 ` [PATCH 1/4 v2] fs/dcache: d_add_ci() needs to complete parallel lookup Sebastian Andrzej Siewior
2022-07-27 11:49 ` [PATCH 2/4 v2] fs/dcache: Disable preemption on i_dir_seq write side on PREEMPT_RT Sebastian Andrzej Siewior
2022-07-27 11:49 ` [PATCH 3/4 v2] fs/dcache: Move the wakeup from __d_lookup_done() to the caller Sebastian Andrzej Siewior
2022-07-27 11:49 ` [PATCH 4/4 v2] fs/dcache: Move wakeup out of i_seq_dir write held region Sebastian Andrzej Siewior
2022-07-30 4:41 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuS2dYPtfed+lHji@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=bigeasy@linutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).