From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Olga Kornievskaia <aglo@umich.edu>,
linux-nfs <linux-nfs@vger.kernel.org>,
Olga Kornievskaia <kolga@netapp.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] problems with alloc_file_pseudo() use in __nfs42_ssc_open()
Date: Thu, 18 Aug 2022 06:52:11 +0100 [thread overview]
Message-ID: <Yv3Ti/niVd5ZVPP+@ZenIV> (raw)
In-Reply-To: <CAOQ4uxgA8jD6KnbuHDevNLsjD-LbEs_y1W6uYMEY6EG_es0o+Q@mail.gmail.com>
On Thu, Aug 18, 2022 at 08:19:54AM +0300, Amir Goldstein wrote:
> NFS spec does not guarantee the safety of the server.
> It's like saying that the Law makes Crime impossible.
> The law needs to be enforced, so if server gets a request
> to COPY from/to an fhandle that resolves as a non-regular file
> (from a rogue or buggy NFS client) the server should return an
> error and not continue to alloc_file_pseudo().
FWIW, my preference would be to have alloc_file_pseudo() reject
directory inodes if it ever gets such.
I'm still not sure that my (and yours, apparently) interpretation
of what Olga said is correct, though.
next prev parent reply other threads:[~2022-08-18 5:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 21:55 [RFC] problems with alloc_file_pseudo() use in __nfs42_ssc_open() Al Viro
2022-08-17 22:32 ` Olga Kornievskaia
2022-08-18 0:01 ` Al Viro
2022-08-18 0:12 ` Olga Kornievskaia
2022-08-18 0:20 ` Al Viro
2022-08-18 5:19 ` Amir Goldstein
2022-08-18 5:52 ` Al Viro [this message]
2022-08-18 13:13 ` Olga Kornievskaia
2022-08-18 14:38 ` Trond Myklebust
2022-08-19 2:51 ` dai.ngo
2022-08-19 14:22 ` Olga Kornievskaia
2022-08-19 15:42 ` dai.ngo
2022-08-19 17:37 ` Olga Kornievskaia
2022-08-19 18:18 ` dai.ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv3Ti/niVd5ZVPP+@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=aglo@umich.edu \
--cc=amir73il@gmail.com \
--cc=kolga@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).