From: Matthew Wilcox <willy@infradead.org>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com,
perex@perex.cz, amadeuszx.slawinski@linux.intel.com,
pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com,
lgirdwood@gmail.com, kai.vehmanen@linux.intel.com,
peter.ujfalusi@linux.intel.com,
ranjani.sridharan@linux.intel.com,
yung-chuan.liao@linux.intel.com, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
andy.shevchenko@gmail.com
Subject: Re: [PATCH v2 1/2] libfs: Introduce tokenize_user_input()
Date: Tue, 30 Aug 2022 19:33:03 +0100 [thread overview]
Message-ID: <Yw5X379ct1PK6wZO@casper.infradead.org> (raw)
In-Reply-To: <20220825164833.3923454-2-cezary.rojewski@intel.com>
On Thu, Aug 25, 2022 at 06:48:32PM +0200, Cezary Rojewski wrote:
> Add new helper function to allow for splitting specified user string
> into a sequence of integers. Internally it makes use of get_options() so
> the returned sequence contains the integers extracted plus an additional
> element that begins the sequence and specifies the integers count.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
> fs/libfs.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> include/linux/fs.h | 1 +
This really has nothing to do with filesystems. Surely
string_helpers.[ch] is the appropriate place for this code?
Also get_options() should probably move its prototype from kernel.h to
string_helpers.h.
next prev parent reply other threads:[~2022-08-30 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 16:48 [PATCH v2 0/2] libfs: Introduce tokenize_user_input() Cezary Rojewski
2022-08-25 16:48 ` [PATCH v2 1/2] " Cezary Rojewski
2022-08-30 18:33 ` Matthew Wilcox [this message]
2022-08-31 16:15 ` Cezary Rojewski
2022-08-25 16:48 ` [PATCH v2 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize_input() Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw5X379ct1PK6wZO@casper.infradead.org \
--to=willy@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).