From: Matthew Bobrowski <repnop@google.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 04/11] fs/notify: constify path
Date: Tue, 23 Aug 2022 07:08:22 +0000 [thread overview]
Message-ID: <YwR85o3b5uzf69ee@google.com> (raw)
In-Reply-To: <20220820181256.1535714-3-viro@zeniv.linux.org.uk>
On Sat, Aug 20, 2022 at 07:12:49PM +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
LGTM. Feel free to add:
Reviewed-by: Matthew Bobrowski <repnop@google.com>
> ---
> fs/notify/fanotify/fanotify.c | 2 +-
> fs/notify/fanotify/fanotify.h | 2 +-
> fs/notify/fanotify/fanotify_user.c | 6 +++---
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c
> index cd7d09a569ff..a2a15bc4df28 100644
> --- a/fs/notify/fanotify/fanotify.c
> +++ b/fs/notify/fanotify/fanotify.c
> @@ -18,7 +18,7 @@
>
> #include "fanotify.h"
>
> -static bool fanotify_path_equal(struct path *p1, struct path *p2)
> +static bool fanotify_path_equal(const struct path *p1, const struct path *p2)
> {
> return p1->mnt == p2->mnt && p1->dentry == p2->dentry;
> }
> diff --git a/fs/notify/fanotify/fanotify.h b/fs/notify/fanotify/fanotify.h
> index 1d9f11255c64..bf6d4d38afa0 100644
> --- a/fs/notify/fanotify/fanotify.h
> +++ b/fs/notify/fanotify/fanotify.h
> @@ -458,7 +458,7 @@ static inline bool fanotify_event_has_path(struct fanotify_event *event)
> event->type == FANOTIFY_EVENT_TYPE_PATH_PERM;
> }
>
> -static inline struct path *fanotify_event_path(struct fanotify_event *event)
> +static inline const struct path *fanotify_event_path(struct fanotify_event *event)
> {
> if (event->type == FANOTIFY_EVENT_TYPE_PATH)
> return &FANOTIFY_PE(event)->path;
> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
> index f0e49a406ffa..4546da4a54f9 100644
> --- a/fs/notify/fanotify/fanotify_user.c
> +++ b/fs/notify/fanotify/fanotify_user.c
> @@ -249,7 +249,7 @@ static struct fanotify_event *get_one_event(struct fsnotify_group *group,
> return event;
> }
>
> -static int create_fd(struct fsnotify_group *group, struct path *path,
> +static int create_fd(struct fsnotify_group *group, const struct path *path,
> struct file **file)
> {
> int client_fd;
> @@ -619,7 +619,7 @@ static ssize_t copy_event_to_user(struct fsnotify_group *group,
> char __user *buf, size_t count)
> {
> struct fanotify_event_metadata metadata;
> - struct path *path = fanotify_event_path(event);
> + const struct path *path = fanotify_event_path(event);
> struct fanotify_info *info = fanotify_event_info(event);
> unsigned int info_mode = FAN_GROUP_FLAG(group, FANOTIFY_INFO_MODES);
> unsigned int pidfd_mode = info_mode & FAN_REPORT_PIDFD;
> @@ -1553,7 +1553,7 @@ static int fanotify_test_fid(struct dentry *dentry)
> }
>
> static int fanotify_events_supported(struct fsnotify_group *group,
> - struct path *path, __u64 mask,
> + const struct path *path, __u64 mask,
> unsigned int flags)
> {
> unsigned int mark_type = flags & FANOTIFY_MARK_TYPE_BITS;
> --
> 2.30.2
/M
next prev parent reply other threads:[~2022-08-23 7:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 18:10 [PATCHES] struct path constification Al Viro
2022-08-20 18:11 ` Subject: [PATCH 01/11] ->getprocattr(): attribute name is const char *, TYVM Al Viro
2022-08-22 13:51 ` Paul Moore
2022-08-22 14:38 ` Casey Schaufler
2022-08-20 18:12 ` [PATCH 02/11] do_sys_name_to_handle(): constify path Al Viro
2022-08-20 18:12 ` [PATCH 03/11] may_linkat(): " Al Viro
2022-08-20 18:12 ` [PATCH 04/11] fs/notify: " Al Viro
2022-08-23 7:08 ` Matthew Bobrowski [this message]
2022-08-20 18:12 ` [PATCH 05/11] overlayfs: " Al Viro
2022-08-20 18:12 ` [PATCH 06/11] do_proc_readlink(): " Al Viro
2022-08-20 18:12 ` [PATCH 07/11] __io_setxattr(): " Al Viro
2022-08-20 18:12 ` [PATCH 08/11] audit_init_parent(): " Al Viro
2022-08-20 18:12 ` [PATCH 09/11] nd_jump_link(): " Al Viro
2022-08-20 18:12 ` [PATCH 10/11] spufs: " Al Viro
2022-08-20 18:12 ` [PATCH 11/11] ecryptfs: " Al Viro
2022-08-26 8:14 ` [PATCHES] struct path constification Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwR85o3b5uzf69ee@google.com \
--to=repnop@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).