From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Yu-li Lin <yulilin@google.com>,
chirantan@chromium.org, dgreid@chromium.org,
fuse-devel <fuse-devel@lists.sourceforge.net>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
suleiman@chromium.org
Subject: Re: [PATCH 2/2] fuse: Implement O_TMPFILE support
Date: Tue, 6 Sep 2022 06:29:28 +0100 [thread overview]
Message-ID: <YxbauDXVcjD7oaiy@ZenIV> (raw)
In-Reply-To: <CAOQ4uxiK-nwpu8eNFByfHgfmEehMD9OEktjNF39ZY2v2NJMBmw@mail.gmail.com>
On Tue, Sep 06, 2022 at 07:58:50AM +0300, Amir Goldstein wrote:
> On Mon, Sep 5, 2022 at 7:25 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
> >
> > On Wed, Aug 31, 2022 at 02:30:40PM -0700, Yu-li Lin wrote:
> > > Thanks for the reference. IIUC, the consensus is to make it atomic,
> > > although there's no agreement on how it should be done. Does that mean
> > > we should hold off on
> > > this patch until atomic temp files are figured out higher in the stack
> > > or do you have thoughts on how the fuse uapi should look like prior to
> > > the vfs/refactoring decision?
> >
> > Here's a patch refactoring the tmpfile kapi to return an open file instead of a
> > dentry.
> >
> > Comments?
>
> IDGI. Why did you need to place do_dentry_open() in all the implementations
> and not inside vfs_tmpfile_new()?
> Am I missing something?
The whole point of that horror is to have open done inside ->tmpfile()
instances...
Al, very unhappy with proposed interface ;-/
next prev parent reply other threads:[~2022-09-06 5:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 10:03 [PATCH 0/2] Support for O_TMPFILE in fuse Chirantan Ekbote
2020-11-09 10:03 ` [PATCH 1/2] uapi/fuse.h: Add message definitions for O_TMPFILE Chirantan Ekbote
2020-11-09 10:03 ` [PATCH 2/2] fuse: Implement O_TMPFILE support Chirantan Ekbote
2020-11-09 11:37 ` Miklos Szeredi
2020-11-10 3:33 ` Chirantan Ekbote
2020-11-10 7:52 ` Miklos Szeredi
2020-11-13 5:19 ` Chirantan Ekbote
2020-11-13 10:52 ` Miklos Szeredi
2020-11-13 12:28 ` Al Viro
2020-11-13 13:54 ` Miklos Szeredi
2022-08-31 2:57 ` Yu-Li Lin
2022-08-31 12:19 ` Miklos Szeredi
2022-08-31 21:30 ` Yu-li Lin
2022-09-05 15:51 ` Miklos Szeredi
2022-09-06 4:58 ` Amir Goldstein
2022-09-06 5:29 ` Al Viro [this message]
2022-09-06 7:23 ` Miklos Szeredi
2022-09-13 1:51 ` Al Viro
2022-09-13 10:20 ` Miklos Szeredi
2022-09-18 13:17 ` [fuse-devel] " Stef Bon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxbauDXVcjD7oaiy@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=chirantan@chromium.org \
--cc=dgreid@chromium.org \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=suleiman@chromium.org \
--cc=yulilin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox