From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE44C07E9D
	for <linux-fsdevel@archiver.kernel.org>; Sat, 24 Sep 2022 04:56:39 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232968AbiIXE4i (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Sat, 24 Sep 2022 00:56:38 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52004 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229533AbiIXE4h (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sat, 24 Sep 2022 00:56:37 -0400
Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47A3D15101C
        for <linux-fsdevel@vger.kernel.org>; Fri, 23 Sep 2022 21:56:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type:
        MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=FEI+JC/0QREit4SgJ6rRzRYPXn5D8NQFZMVD3p6kmVY=; b=qqZBNbIyK6WqtNY3FgVNTEQx73
        0hb9vht4Ffx2rOis7D8p9/72P7YBZ3yVXXu/BDtMzR0HlhYFCPweLIIxx0XLGcTdAov5tkODfG942
        rhk56Qw8GtgazjrDZ2C9X16w4XSFWxLp6Zkb80PtdSrE9/c0CBS0sRrBVF2/mJuLpz3gPWiJbLmdo
        MUG/5J3H0INkcBlg0wWuzSXvmz6MpsCVBA89ouAXbIX13yLgW+5UJeI91Z46ILAbiMAjrORk8iufp
        3159VqlwrGZ+6focPGoOwvwpjZuJBqruI+G0VfGXpBb4D+nniPqxNzZa1qnYx8tM8Gc5ACuwaatNt
        TnkS7ANg==;
Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux))
        id 1obxDN-0039s1-08;
        Sat, 24 Sep 2022 04:56:33 +0000
Date:   Sat, 24 Sep 2022 05:56:33 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Miklos Szeredi <miklos@szeredi.hu>
Cc:     Miklos Szeredi <mszeredi@redhat.com>,
        linux-fsdevel@vger.kernel.org,
        Christian Brauner <brauner@kernel.org>,
        Amir Goldstein <amir73il@gmail.com>,
        David Howells <dhowells@redhat.com>,
        Yu-li Lin <yulilin@google.com>,
        Chirantan Ekbote <chirantan@chromium.org>
Subject: Re: [PATCH v4 04/10] cachefiles: only pass inode to
 *mark_inode_inuse() helpers
Message-ID: <Yy6OASz8zZIpBRNk@ZenIV>
References: <20220922084442.2401223-1-mszeredi@redhat.com>
 <20220922084442.2401223-5-mszeredi@redhat.com>
 <YyyLyY3TUG6IaU3Y@ZenIV>
 <CAJfpegsEi8VSZOXJDbFatvHsKMjuXPCm42GApRG_s1EZobdCAg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJfpegsEi8VSZOXJDbFatvHsKMjuXPCm42GApRG_s1EZobdCAg@mail.gmail.com>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Fri, Sep 23, 2022 at 05:42:01PM +0200, Miklos Szeredi wrote:
> On Thu, 22 Sept 2022 at 18:22, Al Viro <viro@zeniv.linux.org.uk> wrote:
> 
> > I would rather leave unobfuscating that to a separate patch,
> > if not a separate series, but since you are touching
> > cachefiles_unmark_inode_in_use() anyway, might as well
> > get rid of if (inode) in there - it's equivalent to if (true).
> 
> Okay, pushed updated version (also with
> cachefiles_do_unmark_inode_in_use() un-open-coding) to:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#fuse-tmpfile-v5

OK...  I can live with that.  Could you
replace
	cachefiles_do_unmark_inode_in_use(object, file_inode(file));
with
	cachefiles_do_unmark_inode_in_use(object, inode);
in there and repush?  Or I could do cherry-pick and fix it up...