From: Al Viro <viro@zeniv.linux.org.uk>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
David Howells <dhowells@redhat.com>,
Yu-li Lin <yulilin@google.com>,
Chirantan Ekbote <chirantan@chromium.org>
Subject: Re: [PATCH v4 04/10] cachefiles: only pass inode to *mark_inode_inuse() helpers
Date: Thu, 22 Sep 2022 17:22:33 +0100 [thread overview]
Message-ID: <YyyLyY3TUG6IaU3Y@ZenIV> (raw)
In-Reply-To: <20220922084442.2401223-5-mszeredi@redhat.com>
On Thu, Sep 22, 2022 at 10:44:36AM +0200, Miklos Szeredi wrote:
> @@ -78,7 +70,7 @@ void cachefiles_unmark_inode_in_use(struct cachefiles_object *object,
> struct inode *inode = file_inode(file);
^^^^^^^^^^^^^^^^^^^^^^^^
>
> if (inode) {
^^^^^
> - cachefiles_do_unmark_inode_in_use(object, file->f_path.dentry);
> + cachefiles_do_unmark_inode_in_use(object, file_inode(file));
^^^^^^^^^^^^^^^^
>
> if (!test_bit(CACHEFILES_OBJECT_USING_TMPFILE, &object->flags)) {
> atomic_long_add(inode->i_blocks, &cache->b_released);
> @@ -225,7 +220,7 @@ void cachefiles_put_directory(struct dentry *dir)
> inode_lock(dir->d_inode);
> - __cachefiles_unmark_inode_in_use(NULL, dir);
> + __cachefiles_unmark_inode_in_use(NULL, d_inode(dir));
> inode_unlock(dir->d_inode);
Sequence seems identical to cachefiles_do_unmark_inode_in_use(NULL, dir->d_inode)...
Incidentally, this
void cachefiles_unmark_inode_in_use(struct cachefiles_object *object,
struct file *file)
{
struct cachefiles_cache *cache = object->volume->cache;
struct inode *inode = file_inode(file);
if (inode) {
is, er, excessively defensive prog^W^W^Wobfuscation for no reason -
file_inode(file) is never NULL for any opened file. While we are
at it, one of the callers of that puppy also looks interesting:
cachefiles_unmark_inode_in_use(object, object->file);
if (object->file) {
fput(object->file);
object->file = NULL;
}
file_inode(NULL) is not NULL, it's an oops... Fortunately, the
only caller of that one is
if (object->file) {
cachefiles_begin_secure(cache, &saved_cred);
cachefiles_clean_up_object(object, cache);
I would rather leave unobfuscating that to a separate patch,
if not a separate series, but since you are touching
cachefiles_unmark_inode_in_use() anyway, might as well
get rid of if (inode) in there - it's equivalent to if (true).
next prev parent reply other threads:[~2022-09-22 16:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 8:44 [PATCH v4 00/10] fuse tmpfile Miklos Szeredi
2022-09-22 8:44 ` [PATCH v4 01/10] vfs: add vfs_tmpfile_open() helper Miklos Szeredi
2022-09-22 15:23 ` Christian Brauner
2022-09-22 8:44 ` [PATCH v4 02/10] hugetlbfs: cleanup mknod and tmpfile Miklos Szeredi
2022-09-22 8:44 ` [PATCH v4 03/10] cachefiles: tmpfile error handling cleanup Miklos Szeredi
2022-09-22 8:44 ` [PATCH v4 04/10] cachefiles: only pass inode to *mark_inode_inuse() helpers Miklos Szeredi
2022-09-22 15:24 ` Christian Brauner
2022-09-22 16:22 ` Al Viro [this message]
2022-09-23 15:42 ` Miklos Szeredi
2022-09-24 4:56 ` Al Viro
2022-09-24 5:02 ` Miklos Szeredi
2022-09-24 14:37 ` Al Viro
2022-09-22 8:44 ` [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper Miklos Szeredi
2022-09-22 15:26 ` Christian Brauner
2022-09-22 8:44 ` [PATCH v4 06/10] ovl: " Miklos Szeredi
2022-09-22 8:44 ` [PATCH v4 07/10] vfs: make vfs_tmpfile() static Miklos Szeredi
2022-09-22 8:44 ` [PATCH v4 08/10] vfs: move open right after ->tmpfile() Miklos Szeredi
2022-09-22 8:44 ` [PATCH v4 09/10] vfs: open inside ->tmpfile() Miklos Szeredi
2022-09-22 15:27 ` Christian Brauner
2022-09-22 8:44 ` [PATCH v4 10/10] fuse: implement ->tmpfile() Miklos Szeredi
2022-09-22 15:29 ` Christian Brauner
2022-09-29 8:37 ` [PATCH v4 00/10] fuse tmpfile David Howells
2022-09-29 8:44 ` [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper David Howells
2022-09-30 13:53 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyyLyY3TUG6IaU3Y@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chirantan@chromium.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=yulilin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).