From: Al Viro <viro@zeniv.linux.org.uk>
To: "J. R. Okajima" <hooanon05g@gmail.com>
Cc: Ira Weiny <ira.weiny@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH][CFT] [coredump] don't use __kernel_write() on kmap_local_page()
Date: Tue, 4 Oct 2022 00:37:16 +0100 [thread overview]
Message-ID: <YztyLFZJKKTWcMdO@ZenIV> (raw)
In-Reply-To: <4011.1664837894@jrobl>
On Tue, Oct 04, 2022 at 07:58:14AM +0900, J. R. Okajima wrote:
> Al Viro:
> > Argh.... Try this:
> >
> > fix coredump breakage caused by badly tested "[coredump] don't use __kernel_write() on kmap_local_page()"
>
> Thanx, it passed my local test.
>
>
> > * fix for problem that occurs on rather uncommon setups (and hadn't
> > been observed in the wild) sent very late in the cycle.
>
> If the commit was merged in RC versions, I guess someone found the
> problem earlier.
Most likely - the breakage is really not hard to trigger ;-/
Linus, which way would you prefer to handle that? It's
a brown paperbag stuff - the worst I had in quite a while.
Mea maxima culpa ;-/
One variant would be to revert the original patch, put its
(hopefully) fixed variant into -next and let it sit there for
a while. Another is to put this incremental into -next and
merge it into mainline once it gets a sane amount of testing.
Up to you...
next prev parent reply other threads:[~2022-10-03 23:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 22:51 [PATCH][CFT] [coredump] don't use __kernel_write() on kmap_local_page() Al Viro
2022-09-28 17:57 ` Eric W. Biederman
2022-09-28 18:29 ` Al Viro
2022-10-03 3:51 ` Ira Weiny
2022-10-03 10:48 ` J. R. Okajima
2022-10-03 19:31 ` Ira Weiny
2022-10-03 22:18 ` Al Viro
2022-10-03 22:58 ` J. R. Okajima
2022-10-03 23:37 ` Al Viro [this message]
2022-10-04 0:20 ` Linus Torvalds
2022-10-04 0:31 ` Al Viro
2022-10-04 0:37 ` Linus Torvalds
2022-10-04 0:52 ` Al Viro
2022-10-04 6:18 ` Sedat Dilek
2022-10-09 10:37 ` Sedat Dilek
2022-11-09 13:57 ` Geert Uytterhoeven
2022-10-04 2:17 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YztyLFZJKKTWcMdO@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=hooanon05g@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).