From: Matthew Wilcox <willy@infradead.org>
To: I Hsin Cheng <richard120310@gmail.com>
Cc: corbet@lwn.net, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] docs: vfs: Update struct file_system_type
Date: Sun, 23 Mar 2025 14:24:09 +0000 [thread overview]
Message-ID: <Z-AZiYwkE9PsST90@casper.infradead.org> (raw)
In-Reply-To: <20250323034725.32329-1-richard120310@gmail.com>
On Sun, Mar 23, 2025 at 11:47:25AM +0800, I Hsin Cheng wrote:
> The structure definition now in the kernel adds macros defining the
> value of "fs_flags", and the value "FS_NO_DCACHE" no longer exists,
> update it to an existing flag value.
What value does it add to duplicate these flag definitions in the
documentation? I would not do this.
> @@ -140,7 +148,7 @@ members are defined:
> "msdos" and so on
>
> ``fs_flags``
> - various flags (i.e. FS_REQUIRES_DEV, FS_NO_DCACHE, etc.)
> + various flags (i.e. FS_REQUIRES_DEV, FS_BINARY_MOUNTDATA, etc.)
This should be "eg.", not "i.e."
next prev parent reply other threads:[~2025-03-23 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 3:47 [PATCH] docs: vfs: Update struct file_system_type I Hsin Cheng
2025-03-23 14:24 ` Matthew Wilcox [this message]
2025-03-27 14:29 ` I Hsin Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-AZiYwkE9PsST90@casper.infradead.org \
--to=willy@infradead.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=richard120310@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).