From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
brauner@kernel.org, asml.silence@gmail.com, hch@infradead.org,
axboe@kernel.dk, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>, "David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH vfs/for-next 2/3] splice: Move splice_to_socket to net/socket.c
Date: Mon, 24 Mar 2025 15:53:23 -0700 [thread overview]
Message-ID: <Z-HiYx5C_HMWwO14@LQ3V64L9R2> (raw)
In-Reply-To: <20250324141526.5b5b0773@kernel.org>
On Mon, Mar 24, 2025 at 02:15:26PM -0700, Jakub Kicinski wrote:
> On Sat, 22 Mar 2025 20:35:45 +0000 Joe Damato wrote:
> > Eliminate the #ifdef CONFIG_NET from fs/splice.c and move the
> > splice_to_socket helper to net/socket.c, where the other splice socket
> > helpers live (like sock_splice_read and sock_splice_eof).
> >
> > Signed-off-by: Joe Damato <jdamato@fastly.com>
>
> Matter of preference, to some extent, but FWIW:
>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
Thanks for the ACK.
It looks like Jens thinks maybe the code should stay where it is and
given that it might be more "splice related" than networking, it may
be better after all to leave it where it is.
In which case, my apologies for the noise.
next prev parent reply other threads:[~2025-03-24 22:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 20:35 [PATCH vfs/for-next 0/3] Move splice_to_socket to net/socket.c Joe Damato
2025-03-22 20:35 ` [PATCH vfs/for-next 1/3] pipe: Move pipe wakeup helpers out of splice Joe Damato
2025-03-24 22:15 ` Jens Axboe
2025-03-22 20:35 ` [PATCH vfs/for-next 2/3] splice: Move splice_to_socket to net/socket.c Joe Damato
2025-03-24 21:15 ` Jakub Kicinski
2025-03-24 22:53 ` Joe Damato [this message]
2025-03-25 14:40 ` Christian Brauner
2025-03-22 20:35 ` [PATCH vfs/for-next 3/3] net: splice_to_socket: RCT declaration cleanup Joe Damato
2025-03-24 22:14 ` [PATCH vfs/for-next 0/3] Move splice_to_socket to net/socket.c Jens Axboe
2025-03-24 22:51 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-HiYx5C_HMWwO14@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=horms@kernel.org \
--cc=jack@suse.cz \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).