Re: [BUG] 2038 warning is not printed with new mount API

[Jon DeVree <nuxi@vault24.org>]

On Mon, Dec 02, 2024 at 12:55:13 +0100, Christian Brauner wrote:
> IMHO, the best place to log a warning is either at fsmount() time or at
> superblock creation time but then the format of the warning will have to
> be slightly, changed. We could change it to:
> 
> [11526.621600] xfs filesystem supports timestamps until 2038 (0x7ffffff
> 
> libmount will log additional information about the mount to figure out
> what filesystem caused this warning to be logged.
>

Maybe it could log the device node instead of the mount point? Then the
messages from both APIs could remain consistent. One is probably as good
as the other and the other mount related log messages all seem to be
using the device node:

[   39.379071] EXT4-fs (sda3): mounted filesystem with ordered data mode. Quota mode: none.
[   39.574146] XFS (sda4): Mounting V5 Filesystem

I assume that info is available at this point because the filesystems
are able to use it in their log messages, but I could be wrong.

>
> Would that work for you?
>

I don't really have a preference for how its fixed. I reported it
because I happened to notice it go missing after a system upgrade.

I did my best to make a small suggestion despite a lack of expertise in
this area.

-- 
Jon
Doge Wrangler
X(7): A program for managing terminal windows. See also screen(1) and tmux(1).