From: Christoph Hellwig <hch@infradead.org>
To: Long Li <leo.lilong@huawei.com>
Cc: brauner@kernel.org, djwong@kernel.org, cem@kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes
Date: Sun, 24 Nov 2024 22:40:20 -0800 [thread overview]
Message-ID: <Z0Qb1HKqWJKyR5Q0@infradead.org> (raw)
In-Reply-To: <20241125023341.2816630-1-leo.lilong@huawei.com>
On Mon, Nov 25, 2024 at 10:33:40AM +0800, Long Li wrote:
> 1. collect reviewed tag
> 2. Modify the comment of io_size and iomap_ioend_size_aligned().
> 3. Add explain of iomap_ioend_size_aligned() to commit message.
Just curious, did you look into Brian's suggestions to do away
with the rounding up entirely as there is not much practical benefit
in merging behind EOF?
next prev parent reply other threads:[~2024-11-25 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 2:33 [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Long Li
2024-11-25 2:33 ` [PATCH v4 2/2] xfs: clean up xfs_end_ioend() to reuse local variables Long Li
2024-11-25 6:40 ` Christoph Hellwig [this message]
2024-11-25 13:42 ` [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Long Li
2024-11-26 6:28 ` Christoph Hellwig
2024-11-26 6:53 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0Qb1HKqWJKyR5Q0@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=houtao1@huawei.com \
--cc=leo.lilong@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox