From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52FBA1EEE6 for ; Thu, 12 Dec 2024 13:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734010089; cv=none; b=L8V/YmEpMloQ1EocEJQIrg2p+eDl6yCt0UtraI+vHoMpSMQbzj8+Fs5Hg4eR9A5SV1gnFqF5BSHlLdCOXPvjSDM82knFIBJ0hkxV47KsA2s8NQBPz5UWp5d+FP14H/6XlFzvidS8BkM38CtPhr0oCuyio5+v/YzRHPp4JS1GslI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734010089; c=relaxed/simple; bh=cvjPOTd1DpEMLuCP1gjefrv8LE6PWfqZ2TNSnsCsxqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o01sA/CEhreWSAbDlOWhxx8qYLZaKqnC70SBZSZZpHC6hjjlJNNXy4E+6zMaDhp7iKx3dur2dERimocXtM6y7nwvnv6fzLOYZ2zYZZZPXtuS5yxrKeB06h+9eagIvT2u92/cZw8NQTDvXQ0HxT2rjleVmo09sTPcxq9/xeSji4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HdJgvD6/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HdJgvD6/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734010086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B8ga3Fxf0BDxyz8CsLNkt3r/yd6VG4wP4xOFplptOfc=; b=HdJgvD6/kDMTDY7+UM1sr0BwrN5vmwZ3cEntJPZrYP3+hGmJClmR3cRxwJpm2xm/CqhM2X Wr2ViDXGZ386dgikU2bZfRZai7S10GrK8ka3A7Jfj1qNQH0GalW19YVSydyXmx5PRNzbhE sigh0AggGsqN/EXJx3QQ/HspfNqFkcs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119-MqecxjqKOgSW0hMDXjXjzg-1; Thu, 12 Dec 2024 08:28:03 -0500 X-MC-Unique: MqecxjqKOgSW0hMDXjXjzg-1 X-Mimecast-MFC-AGG-ID: MqecxjqKOgSW0hMDXjXjzg Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A0341956096; Thu, 12 Dec 2024 13:28:01 +0000 (UTC) Received: from bfoster (unknown [10.22.90.12]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91DB7195606C; Thu, 12 Dec 2024 13:28:00 +0000 (UTC) Date: Thu, 12 Dec 2024 08:29:47 -0500 From: Brian Foster To: Christoph Hellwig Cc: Christian Brauner , "Darrick J. Wong" , Carlos Maiolino , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: RFC: iomap patches for zoned XFS Message-ID: References: <20241211085420.1380396-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241211085420.1380396-1-hch@lst.de> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On Wed, Dec 11, 2024 at 09:53:40AM +0100, Christoph Hellwig wrote: > Hi all, > > this series contains the iomap prep work to support zoned XFS. > > The biggest changes are: > > - an option to reuse the ioend code for direct writes in addition to the > current use for buffered writeback, which allows the file system to > track completions on a per-bio basis instead of the current end_io > callback which operates on the entire I/O. > Note that it might make sense to split the ioend code from > buffered-io.c into its own file with this. Let me know what you think > of that and I can include it in the next version > - change of the writeback_ops so that the submit_bio call can be done by > the file system. Note that btrfs will also need this eventually when > it starts using iomap > - helpers to split ioend to the zone append queue_limits that plug > into the previous item above. > - a bunch of changes for slightly different merge conditions when using > zone append. Note that btrfs wants something similar also for > compressed I/O, which might be able to share some code. For now > the flags use zone append naming, but we can change that if it gets > used elsewhere. > - passing private data to a few more helper > > The XFS changes to use this will be posted to the xfs list only to not > spam fsdevel too much. > Orthogonal to the couple or so questions inline, the series LGTM: Reviewed-by: Brian Foster