From: Matthew Wilcox <willy@infradead.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org,
bfoster@redhat.com, David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 04/11] mm: add PG_dropbehind folio flag
Date: Fri, 20 Dec 2024 14:38:09 +0000 [thread overview]
Message-ID: <Z2WBUX2OKLinNuFZ@casper.infradead.org> (raw)
In-Reply-To: <wi3n3k26uizgm3hhbz4qxi6k342e5gxprtvqpzdqftekutfy65@3usaz63baobt>
On Fri, Dec 20, 2024 at 01:08:39PM +0200, Kirill A. Shutemov wrote:
> On Fri, Dec 13, 2024 at 08:55:18AM -0700, Jens Axboe wrote:
> > Add a folio flag that file IO can use to indicate that the cached IO
> > being done should be dropped from the page cache upon completion.
> >
> > Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> + David, Vlastimil.
>
> I think we should consider converting existing folio_set_reclaim() /
> SetPageReclaim() users to the new flag. From a quick scan, all of them
> would benefit from dropping the page after writeback is complete instead
> of leaving the folio on the LRU.
Ooh, that would be nice. Removes the overloading of PG_reclaim with
PG_readahead, right?
next prev parent reply other threads:[~2024-12-20 14:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:55 [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-13 15:55 ` [PATCH 01/11] mm/filemap: change filemap_create_folio() to take a struct kiocb Jens Axboe
2024-12-20 10:51 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 02/11] mm/filemap: use page_cache_sync_ra() to kick off read-ahead Jens Axboe
2024-12-20 10:56 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 03/11] mm/readahead: add folio allocation helper Jens Axboe
2024-12-20 10:59 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 04/11] mm: add PG_dropbehind folio flag Jens Axboe
2024-12-20 11:08 ` Kirill A. Shutemov
2024-12-20 14:38 ` Matthew Wilcox [this message]
2024-12-20 15:11 ` Kirill A. Shutemov
2024-12-20 15:45 ` Matthew Wilcox
2024-12-20 15:03 ` David Hildenbrand
2024-12-20 15:12 ` Kirill A. Shutemov
2024-12-20 15:20 ` David Hildenbrand
2024-12-13 15:55 ` [PATCH 05/11] mm/readahead: add readahead_control->dropbehind member Jens Axboe
2024-12-20 11:09 ` Kirill A. Shutemov
2024-12-13 15:55 ` [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper Jens Axboe
2024-12-20 11:13 ` Kirill A. Shutemov
2024-12-20 14:16 ` Jens Axboe
2024-12-13 15:55 ` [PATCH 07/11] fs: add RWF_DONTCACHE iocb and FOP_DONTCACHE file_operations flag Jens Axboe
2024-12-13 15:55 ` [PATCH 08/11] mm/filemap: add read support for RWF_DONTCACHE Jens Axboe
2024-12-13 15:55 ` [PATCH 09/11] mm/filemap: drop streaming/uncached pages when writeback completes Jens Axboe
2024-12-13 15:55 ` [PATCH 10/11] mm/filemap: add filemap_fdatawrite_range_kick() helper Jens Axboe
2024-12-13 15:55 ` [PATCH 11/11] mm: call filemap_fdatawrite_range_kick() after IOCB_DONTCACHE issue Jens Axboe
2024-12-17 15:58 ` [PATCHSET v7 0/11] Uncached buffered IO Jens Axboe
2024-12-18 17:16 ` [PATCH] nfs: flag as supporting FOP_DONTCACHE Mike Snitzer
2024-12-19 16:54 ` Jens Axboe
2024-12-20 11:25 ` [PATCHSET v7 0/11] Uncached buffered IO Kirill A. Shutemov
2024-12-20 14:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2WBUX2OKLinNuFZ@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=clm@meta.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).