Re: [PATCH] sysv: Remove the filesystem

Matthew Wilcox
2025-01-06T20:41:33Z

On Mon, Jan 06, 2025 at 05:24:01PM +0100, Jan Kara wrote:
> Since 2002 (change "Replace BKL for chain locking with sysvfs-private
> rwlock") the sysv filesystem was doing IO under a rwlock in its
> get_block() function (yes, a non-sleepable lock hold over a function
> used to read inode metadata for all reads and writes). Nobody noticed
> until syzbot in 2023 [1]. This shows nobody is using the filesystem.
> Just drop it.
>
> [1] https://lore.kernel.org/all/0000000000000ccf9a05ee84f5b0@google.com/
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> What do people think about this? Or should we perhaps go through a (short)
> deprecation period where we warn about removal?

The sooner we delete filesystems, the fewer syzbot bugs we get about
them. Let's delete as many as we can.