Re: [PATCH] sysv: Remove the filesystem

Jeff Layton
2025-01-06T19:52:13Z

On Mon, 2025-01-06 at 17:24 +0100, Jan Kara wrote:
> Since 2002 (change "Replace BKL for chain locking with sysvfs-private
> rwlock") the sysv filesystem was doing IO under a rwlock in its
> get_block() function (yes, a non-sleepable lock hold over a function
> used to read inode metadata for all reads and writes). Nobody noticed
> until syzbot in 2023 [1]. This shows nobody is using the filesystem.
> Just drop it.
>
> [1] https://lore.kernel.org/all/0000000000000ccf9a05ee84f5b0@google.com/
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> What do people think about this? Or should we perhaps go through a (short)
> deprecation period where we warn about removal?
>

FWIW, it was orphaned in 2023:

commit a8cd2990b694ed2c0ef0e8fc80686c664b4ebbe5
Author: Christoph Hellwig <hch@lst.de>
Date: Thu Feb 16 07:29:22 2023 +0100

orphan sysvfs

This code has been stale for years and I have no way to test it.

Given how long this was broken with no one noticing, and since it's not
being adequately tested, I vote we remove it.

Reviewed-by: Jeff Layton <jlayton@kernel.org>