From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA4301547F0 for ; Thu, 13 Feb 2025 15:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739460303; cv=none; b=e9oebtHeyWSW0STwKLk272/FqS1hXZC9xadzPLP9Vd/z7ljzkSIB2UrBKZDwtHZckSlOBB0LZ6InAwSiTjU9Aw1L9xbjfGONqQs3nHD1QrHvWTLYV9bMM2MEOiHyiYsJc2XFa14o5KQIg5gBSBf6uf81xueiy2Z25OcnuiCXpug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739460303; c=relaxed/simple; bh=hFyGp/Eg80nyAboL8LuIFjshUMLGFsUswB0uf6lF/jA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FuC/grQPI8/w5ga9afFv6Gjnoe26Id+KgMezb1WxAh/G4eDUlm3Uy/nN1RNSBGErWcamgCFRhIW4Q5jCaXsKlqf98hIHqN/TXN7CUm2S6xWIcFhYSAZ5NVTuPXKWhmkwZpNUpOm7QHctzXU8ASpVySKm9VErfqfGiaMCtuvClQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XidAr4/A; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XidAr4/A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739460300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i4Tw6QD+476TH3jdgkW3TNg9gzO7dlh/ltoiIiLZQbI=; b=XidAr4/A0HvCRPv170ZjISNJKymUyyy3DIcgw2mP2FcN+5MeS/kv3yTHeyM+PUdeNwaMd1 gyBaovAhxVwBVO77gEZ6B5XgjYBqXdHlQFIe81uZkHWjo3jSpMej6uE//rGq8mOwJ3q9sz QUNksOSV+YGhgP6uSblzuEIGn12yND0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-SKQjzEB6OQereMW9-vvF5A-1; Thu, 13 Feb 2025 10:24:56 -0500 X-MC-Unique: SKQjzEB6OQereMW9-vvF5A-1 X-Mimecast-MFC-AGG-ID: SKQjzEB6OQereMW9-vvF5A Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED5BE19373D8; Thu, 13 Feb 2025 15:24:53 +0000 (UTC) Received: from bfoster (unknown [10.22.88.88]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0B1C3300018D; Thu, 13 Feb 2025 15:24:52 +0000 (UTC) Date: Thu, 13 Feb 2025 10:27:18 -0500 From: Brian Foster To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, "Darrick J . Wong" Subject: Re: [PATCH 04/10] dax: advance the iomap_iter in the read/write path Message-ID: References: <20250212135712.506987-1-bfoster@redhat.com> <20250212135712.506987-5-bfoster@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Wed, Feb 12, 2025 at 10:55:12PM -0800, Christoph Hellwig wrote: > On Wed, Feb 12, 2025 at 08:57:06AM -0500, Brian Foster wrote: > > DAX reads and writes flow through dax_iomap_iter(), which has one or > > more subtleties in terms of how it processes a range vs. what is > > specified in the iomap_iter. To keep things simple and remove the > > dependency on iomap_iter() advances, convert a positive return from > > dax_iomap_iter() to the new advance and status return semantics. The > > advance can be pushed further down in future patches. > > Looks good: > > Reviewed-by: Christoph Hellwig > > (and looking forward to the future patches..) > Thanks. The patch to push this down a level seems to be working now so I'll include it in v2. Brian