From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 268CE26B0BD for ; Thu, 13 Feb 2025 15:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739460313; cv=none; b=gP89D0ZuApE6r2ooMWqi72GzdyVusnm6eJehMZuBHhjl5fdQn5duyKUQGkYZWdePuAkgU+acPC2+NcJ6uV4VZwxg8qh4OyVio/RHCN6Hkr3K+hvzWH/6O1QiX4/RnKpnt19y2PeIEEDWU3joUDQTdJuaY7Gvn9z1HoXjzl8AfC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739460313; c=relaxed/simple; bh=qroDevgXEZz2C/CItepIJ5ZwJT4MGtAx+nNtt24ca3s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cF1hT3RK1HhGI67w0ckHLnar2Nx71VqD5qItoAFZCcSYLFcHWiIFQFWQt9uXqjiBFROXuTpzwynU1WGxqr3HNfiAV0D7mI8uiCyL0M/LoFPe0IWeCP4qjgA/nxzRn5fMDjkI8NI+AJSa450uBAP4zwSbqJ1+2pUmzsEiOLF/LZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Io/zC20z; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Io/zC20z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739460311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=It7+x6W7wvGYoNCVJXcV6cFYTwCk46Qqe/wvmYHAHvA=; b=Io/zC20zHma7VdypqlPbxVz4XJ/l71eGmTaMLLA7JM1MgOdEUEqM+dT6XF2DKyFHZawn3W GI34VWQf/pUeam6RqS9HTIMT/QYV/3wmmy2DsSRYQCa5/P7xY61b1YYzhf6Ud+MbVhCNMk KxlEV+klabTzwI9KTbFfqMxg52MFuwY= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-hu7n3gJYMXiIvhb3yZWDGA-1; Thu, 13 Feb 2025 10:25:09 -0500 X-MC-Unique: hu7n3gJYMXiIvhb3yZWDGA-1 X-Mimecast-MFC-AGG-ID: hu7n3gJYMXiIvhb3yZWDGA Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91538180034A; Thu, 13 Feb 2025 15:25:07 +0000 (UTC) Received: from bfoster (unknown [10.22.88.88]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 84EB018004A7; Thu, 13 Feb 2025 15:25:06 +0000 (UTC) Date: Thu, 13 Feb 2025 10:27:32 -0500 From: Brian Foster To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, "Darrick J . Wong" Subject: Re: [PATCH 05/10] dax: advance the iomap_iter on zero range Message-ID: References: <20250212135712.506987-1-bfoster@redhat.com> <20250212135712.506987-6-bfoster@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Wed, Feb 12, 2025 at 10:57:02PM -0800, Christoph Hellwig wrote: > On Wed, Feb 12, 2025 at 08:57:07AM -0500, Brian Foster wrote: > > @@ -1372,33 +1371,35 @@ static s64 dax_zero_iter(struct iomap_iter *iter, bool *did_zero) > > */ > > if (iomap->flags & IOMAP_F_SHARED) > > invalidate_inode_pages2_range(iter->inode->i_mapping, > > - pos >> PAGE_SHIFT, > > - (pos + length - 1) >> PAGE_SHIFT); > > + iter->pos >> PAGE_SHIFT, > > + (iter->pos + length - 1) >> PAGE_SHIFT); > > Relaly long line here. I think this would benefit from normal two > tab argument continuation indentation (and a less stupid calling > convention for invalidate_inode_pages2_range, but that's a different > story). > Yeah, I'll change it. Brian