From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH 09/10] iomap: remove unnecessary advance from iomap_iter()
Date: Thu, 13 Feb 2025 10:27:52 -0500 [thread overview]
Message-ID: <Z64PeMFlUtKoSRYQ@bfoster> (raw)
In-Reply-To: <Z62YYEKE8n8qIsMc@infradead.org>
On Wed, Feb 12, 2025 at 10:59:44PM -0800, Christoph Hellwig wrote:
> On Wed, Feb 12, 2025 at 08:57:11AM -0500, Brian Foster wrote:
> > + ret = (iter->len > 0) ? 1 : 0;
> > + if (iter->processed < 0)
> > + ret = iter->processed;
> > + else if (!advanced && !stale)
> > ret = 0;
>
> Maybe reshuffle this a bit as:
>
> if (iter->processed < 0)
> ret = iter->processed;
> else if (iter->len == 0 || (!advanced && !stale))
> ret = 0;
> else
> ret = 1;
>
> Otherwise this looks great!
>
Ack, I like that better. Thanks for the feedback.
Brian
next prev parent reply other threads:[~2025-02-13 15:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 13:57 [PATCH 00/10] iomap: incremental advance conversion -- phase 2 Brian Foster
2025-02-12 13:57 ` [PATCH 01/10] iomap: advance the iter directly on buffered read Brian Foster
2025-02-13 6:50 ` Christoph Hellwig
2025-02-13 15:24 ` Brian Foster
2025-02-12 13:57 ` [PATCH 02/10] iomap: advance the iter on direct I/O Brian Foster
2025-02-13 6:51 ` Christoph Hellwig
2025-02-13 15:25 ` Brian Foster
2025-02-12 13:57 ` [PATCH 03/10] iomap: convert misc simple ops to incremental advance Brian Foster
2025-02-13 6:54 ` Christoph Hellwig
2025-02-13 15:26 ` Brian Foster
2025-02-12 13:57 ` [PATCH 04/10] dax: advance the iomap_iter in the read/write path Brian Foster
2025-02-13 6:55 ` Christoph Hellwig
2025-02-13 15:27 ` Brian Foster
2025-02-12 13:57 ` [PATCH 05/10] dax: advance the iomap_iter on zero range Brian Foster
2025-02-13 6:57 ` Christoph Hellwig
2025-02-13 15:27 ` Brian Foster
2025-02-12 13:57 ` [PATCH 06/10] dax: advance the iomap_iter on unshare range Brian Foster
2025-02-12 13:57 ` [PATCH 07/10] dax: advance the iomap_iter on dedupe range Brian Foster
2025-02-12 13:57 ` [PATCH 08/10] dax: advance the iomap_iter on pte and pmd faults Brian Foster
2025-02-12 13:57 ` [PATCH 09/10] iomap: remove unnecessary advance from iomap_iter() Brian Foster
2025-02-13 6:59 ` Christoph Hellwig
2025-02-13 15:27 ` Brian Foster [this message]
2025-02-12 13:57 ` [PATCH 10/10] iomap: rename iomap_iter processed field to status Brian Foster
2025-02-13 7:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z64PeMFlUtKoSRYQ@bfoster \
--to=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).