From: Matthew Wilcox <willy@infradead.org>
To: Yuan Tan <tanyuan@tinylab.org>
Cc: axboe@kernel.dk,
syzbot+f2aaf773187f5cae54f3@syzkaller.appspotmail.com,
linux-block@vger.kernel.org, akpm@linux-foundation.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, syzkaller-bugs@googlegroups.com,
falcon@tinylab.org
Subject: Re: [PATCH] block: add lock for safe nrpages access in invalidate_bdev()
Date: Mon, 10 Mar 2025 17:11:22 +0000 [thread overview]
Message-ID: <Z88dOtsjiIUx6apV@casper.infradead.org> (raw)
In-Reply-To: <20250310165400.3166618-1-tanyuan@tinylab.org>
On Mon, Mar 10, 2025 at 09:54:00AM -0700, Yuan Tan wrote:
> Syzbot reported a data-race in __filemap_add_folio / invalidate_bdev[1]
> due to concurrent access to mapping->nrpages.
> Adds a lock around the access to nrpages.
Did you even read my analysis? This is a grossly inappropriate fix.
NAK.
prev parent reply other threads:[~2025-03-10 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 9:40 [syzbot] [mm?] [fs?] KCSAN: data-race in __filemap_add_folio / invalidate_bdev (8) syzbot
2025-03-10 15:28 ` Matthew Wilcox
2025-03-10 16:54 ` [PATCH] block: add lock for safe nrpages access in invalidate_bdev() Yuan Tan
2025-03-10 17:11 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z88dOtsjiIUx6apV@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=falcon@tinylab.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+f2aaf773187f5cae54f3@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tanyuan@tinylab.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).