From: Matthew Wilcox <willy@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 17/27] f2fs: Add f2fs_get_node_folio()
Date: Sat, 1 Mar 2025 02:03:24 +0000 [thread overview]
Message-ID: <Z8Jq7PQNRDu_zmGq@casper.infradead.org> (raw)
In-Reply-To: <39268c84-f514-48b7-92f6-b298d55dfc62@kernel.org>
On Sat, Mar 01, 2025 at 09:15:53AM +0800, Chao Yu wrote:
> > struct page *f2fs_get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid)
> > {
> > - return __get_node_page(sbi, nid, NULL, 0);
> > + struct folio *folio = __get_node_folio(sbi, nid, NULL, 0);
> > +
>
> if (IS_ERR(folio))
> return ERR_CAST(folio));
>
> > + return &folio->page;
No need. It'll probably generate the saame code (or if not, it'll
generate worse code) and this wrapper function has to be deleted in
the next six to nine months anyway. We use this idiom extensively.
next prev parent reply other threads:[~2025-03-01 2:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 5:51 [PATCH 00/27] f2fs folio conversions for v6.15 Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 01/27] f2fs: Add f2fs_folio_wait_writeback() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 02/27] mm: Remove wait_for_stable_page() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 03/27] f2fs: Add f2fs_folio_put() Matthew Wilcox (Oracle)
2025-02-21 4:55 ` Jaegeuk Kim
2025-02-24 7:19 ` Jaegeuk Kim
2025-02-27 21:31 ` Jaegeuk Kim
2025-02-18 5:51 ` [PATCH 04/27] f2fs: Convert f2fs_flush_inline_data() to use a folio Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 05/27] f2fs: Convert f2fs_sync_node_pages() " Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 06/27] f2fs: Pass a folio to flush_dirty_inode() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 07/27] f2fs: Convert f2fs_fsync_node_pages() to use a folio Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 08/27] f2fs: Convert last_fsync_dnode() " Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 09/27] f2fs: Return a folio from last_fsync_dnode() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 10/27] f2fs: Add f2fs_grab_cache_folio() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 11/27] mm: Remove grab_cache_page_write_begin() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 12/27] f2fs: Use a folio in __get_node_page() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 13/27] f2fs: Use a folio in do_write_page() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 14/27] f2fs: Convert f2fs_write_end_io() to use a folio_iter Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 15/27] f2fs: Mark some functions as taking a const page pointer Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 16/27] f2fs: Convert f2fs_in_warm_node_list() to take a folio Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 17/27] f2fs: Add f2fs_get_node_folio() Matthew Wilcox (Oracle)
2025-03-01 1:15 ` Chao Yu
2025-03-01 1:59 ` Matthew Wilcox
2025-03-01 2:03 ` Matthew Wilcox [this message]
2025-03-03 3:15 ` Chao Yu
2025-02-18 5:51 ` [PATCH 18/27] f2fs: Use a folio throughout f2fs_truncate_inode_blocks() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 19/27] f2fs: Use a folio throughout __get_meta_page() Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 20/27] f2fs: Hoist the page_folio() call to the start of f2fs_merge_page_bio() Matthew Wilcox (Oracle)
2025-02-28 7:25 ` Chao Yu
2025-02-18 5:51 ` [PATCH 21/27] f2fs: Add f2fs_get_read_data_folio() Matthew Wilcox (Oracle)
2025-02-28 7:37 ` Chao Yu
2025-02-18 5:51 ` [PATCH 22/27] f2fs: Add f2fs_get_lock_data_folio() Matthew Wilcox (Oracle)
2025-02-28 7:37 ` Chao Yu
2025-02-18 5:51 ` [PATCH 23/27] f2fs: Convert move_data_page() to use a folio Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 24/27] f2fs: Convert truncate_partial_data_page() " Matthew Wilcox (Oracle)
2025-02-18 5:51 ` [PATCH 25/27] f2fs: Convert gc_data_segment() " Matthew Wilcox (Oracle)
2025-02-18 5:52 ` [PATCH 26/27] f2fs: Add f2fs_find_data_folio() Matthew Wilcox (Oracle)
2025-02-18 5:52 ` [PATCH 27/27] mm: Remove wait_on_page_locked() Matthew Wilcox (Oracle)
2025-02-21 2:27 ` [PATCH 00/27] f2fs folio conversions for v6.15 Jaegeuk Kim
2025-03-04 8:04 ` Chao Yu
2025-03-04 17:10 ` [f2fs-dev] " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8Jq7PQNRDu_zmGq@casper.infradead.org \
--to=willy@infradead.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).