From: Eric Biggers <ebiggers@kernel.org>
To: syzbot <syzbot+93e495f6a4f748827c88@syzkaller.appspotmail.com>
Cc: jaegeuk@kernel.org, linux-fscrypt@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, tytso@mit.edu
Subject: Re: [syzbot] [fscrypt?] WARNING in fscrypt_destroy_keyring
Date: Mon, 13 Mar 2023 15:17:48 -0700 [thread overview]
Message-ID: <ZA+hDI+bIx2H7QYz@sol.localdomain> (raw)
In-Reply-To: <00000000000044651705f6ca1e30@google.com>
On Mon, Mar 13, 2023 at 08:53:55AM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: fe15c26ee26e Linux 6.3-rc1
> git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci
> console output: https://syzkaller.appspot.com/x/log.txt?x=14e2d88ac80000
> kernel config: https://syzkaller.appspot.com/x/.config?x=7573cbcd881a88c9
> dashboard link: https://syzkaller.appspot.com/bug?extid=93e495f6a4f748827c88
> compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
> userspace arch: arm64
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16171188c80000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15ac08dac80000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/89d41abd07bd/disk-fe15c26e.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/fa75f5030ade/vmlinux-fe15c26e.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/590d0f5903ee/Image-fe15c26e.gz.xz
> mounted in repro: https://storage.googleapis.com/syzbot-assets/bf3b409baf10/mount_0.gz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+93e495f6a4f748827c88@syzkaller.appspotmail.com
>
> EXT4-fs (loop0): mounted filesystem 76b65be2-f6da-4727-8c75-0525a5b65a09 without journal. Quota mode: writeback.
> fscrypt: AES-256-CTS-CBC using implementation "cts-cbc-aes-ce"
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 5945 at fs/crypto/keyring.c:237 fscrypt_destroy_keyring+0x164/0x240 fs/crypto/keyring.c:237
Very impressive find by syzbot! fscrypt_destroy_keyring() needs to be called
after security_sb_delete(), not before. Fix is
https://lore.kernel.org/linux-fscrypt/20230313221231.272498-2-ebiggers@kernel.org
- Eric
prev parent reply other threads:[~2023-03-13 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 15:53 [syzbot] [fscrypt?] WARNING in fscrypt_destroy_keyring syzbot
2023-03-13 22:17 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA+hDI+bIx2H7QYz@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+93e495f6a4f748827c88@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox