From: Luis Chamberlain <mcgrof@kernel.org>
To: ye xingchen <yexingchen116@gmail.com>
Cc: akpm@linux-foundation.org, chi.minghao@zte.com.cn,
hch@infradead.org, keescook@chromium.org, linmiaohe@huawei.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, vbabka@suse.cz, willy@infradead.org,
ye.xingchen@zte.com.cn, yzaikin@google.com
Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file
Date: Fri, 24 Mar 2023 11:11:34 -0700 [thread overview]
Message-ID: <ZB3n1pJZsOK+E/Zk@bombadil.infradead.org> (raw)
In-Reply-To: <20230324062408.49217-1-ye.xingchen@zte.com.cn>
On Fri, Mar 24, 2023 at 06:24:08AM +0000, ye xingchen wrote:
> >$ ./scripts/bloat-o-meter vmlinux.old vmlinux
> >add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4)
> >Function old new delta
> >vm_compaction - 320 +320
> >kcompactd_init 167 193 +26
> >proc_dointvec_minmax_warn_RT_change 104 10 -94
> >vm_table 2112 1856 -256
> >Total: Before=19287558, After=19287554, chg -0.00%
> >
> >So I don't think we need to pause this move or others where are have savings.
> >
> >Minghao, can you fix the commit log, and explain how you are also saving
> >4 bytes as per the above bloat-o-meter results?
>
> $ ./scripts/bloat-o-meter vmlinux vmlinux.new
> add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
> Function old new delta
> vm_compaction - 320 +320
> kcompactd_init 180 210 +30
> vm_table 2112 1856 -256
> Total: Before=21104198, After=21104292, chg +0.00%
>
> In my environment, kcompactd_init increases by 30 instead of 26.
> And proc_dointvec_minmax_warn_RT_change No expansion.
How about a defconfig + compaction enabled? Provide that information
and let Vlastimal ACK/NACK the patch.
Luis
next prev parent reply other threads:[~2023-03-24 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 2:46 [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file ye.xingchen
2023-03-22 8:35 ` Christoph Hellwig
2023-03-23 16:19 ` Vlastimil Babka
2023-03-23 19:39 ` Luis Chamberlain
2023-03-24 6:24 ` ye xingchen
2023-03-24 18:11 ` Luis Chamberlain [this message]
2023-03-27 2:49 ` ye xingchen
2023-03-27 10:27 ` Vlastimil Babka
2023-03-27 3:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB3n1pJZsOK+E/Zk@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chi.minghao@zte.com.cn \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yexingchen116@gmail.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).