From: Matthew Wilcox <willy@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] nfs: use vfs setgid helper
Date: Tue, 14 Mar 2023 12:37:03 +0000 [thread overview]
Message-ID: <ZBBqbz7LeSZLr7s/@casper.infradead.org> (raw)
In-Reply-To: <20230313-fs-nfs-setgid-v2-1-9a59f436cfc0@kernel.org>
On Tue, Mar 14, 2023 at 12:51:10PM +0100, Christian Brauner wrote:
> +++ b/include/linux/fs.h
> @@ -2675,6 +2675,8 @@ extern struct inode *new_inode(struct super_block *sb);
> extern void free_inode_nonrcu(struct inode *inode);
> extern int setattr_should_drop_suidgid(struct mnt_idmap *, struct inode *);
> extern int file_remove_privs(struct file *);
> +int setattr_should_drop_sgid(struct mnt_idmap *idmap,
> + const struct inode *inode);
Is there a reason that setattr_should_drop_sgid() doesn't take a
const struct mnt_idmap pointer?
next prev parent reply other threads:[~2023-03-14 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:51 [PATCH v2] nfs: use vfs setgid helper Christian Brauner
2023-03-14 12:37 ` Matthew Wilcox [this message]
2023-03-14 13:08 ` Christian Brauner
2023-03-28 8:30 ` Christian Brauner
2023-03-30 5:45 ` Christoph Hellwig
2023-03-30 6:57 ` Christian Brauner
2023-04-11 16:54 ` Anna Schumaker
2023-04-12 8:58 ` Christian Brauner
2023-04-11 17:10 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBBqbz7LeSZLr7s/@casper.infradead.org \
--to=willy@infradead.org \
--cc=anna@kernel.org \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).