From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE761C05027 for ; Tue, 14 Mar 2023 17:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjCNRaU (ORCPT ); Tue, 14 Mar 2023 13:30:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbjCNRaS (ORCPT ); Tue, 14 Mar 2023 13:30:18 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D7A394A7D; Tue, 14 Mar 2023 10:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=eUIJTM7TbkoVZI0j+F8ZKH5X7e B48XJw0RR2yz6tT/PjMswRJjY+dkDmxXc6sCGMg1C4CJ+8iLnpXKbc9rjBY31/jFlSDcFMlYN5QTY py+Kqj3Rzd3f3kql64+bwRMuY9kLTUrfKeM6ZgF7F/8W3SQqxKwU/Cqa8/CSSFnM8vCKld3ya7DGe 2NxmNhXY0cnZAykUsRNZWJX808kO4UWXMEX84GCM2OubDaDuEDia+lUiYBY0qjgXi/JkONUgD5K3d GzAqabDZKA5aVb570+V/GNZjWtQdrYslTi4Nhc2MyDvsqjPGjwryuJJQZcM1nKFS2N8XvJBpL9sj/ q5NH2PIQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pc8TJ-00B16H-0V; Tue, 14 Mar 2023 17:30:01 +0000 Date: Tue, 14 Mar 2023 10:30:01 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v17 01/14] splice: Clean up direct_splice_read() a bit Message-ID: References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308165251.2078898-2-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig