From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62219C76188 for ; Wed, 5 Apr 2023 19:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232343AbjDETak (ORCPT ); Wed, 5 Apr 2023 15:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231230AbjDETaj (ORCPT ); Wed, 5 Apr 2023 15:30:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59E85251 for ; Wed, 5 Apr 2023 12:30:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 712D863D59 for ; Wed, 5 Apr 2023 19:30:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C03D3C433D2; Wed, 5 Apr 2023 19:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680723037; bh=FOb4mP5HMd4dql42lhDLMpQpdMg1Qi0NyF0Er/AxZ78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QjaGVtf3sWjKCxzdqfkGcU/EKchcly7kFvVoQCO26NGs6ei2v4JxOXToTRfGZnb7V mTQMGEOJsPpkny06xEXQC+UR6FNaB86h6mPRMroE4DJN9kyaHV0adpDKaA1HUNuTT1 9tGoz8AzhQOMwzFux4whPplTq06AQKoV72Yk21Mz3MZnPIeiG2o/Z8DKZZJvz+SDX0 arySsCH0xOzopXtLgxOdovfuxTgQL43zHMt0/qukeqR3AHjZ85wYpF6aqwSETixemi R8uUmYafZAPz0HmM5asmX36ZdpYskaUXFasUAzx2aPYN2Q7Tt9wQQTeJegba5xzJzo 3JddoZTLHKs5Q== Date: Wed, 5 Apr 2023 14:30:36 -0500 From: Seth Forshee To: Christian Brauner Cc: Al Viro , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 2/5] pnode: pass mountpoint directly Message-ID: References: <20230202-fs-move-mount-replace-v2-0-f53cd31d6392@kernel.org> <20230202-fs-move-mount-replace-v2-2-f53cd31d6392@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202-fs-move-mount-replace-v2-2-f53cd31d6392@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Mar 28, 2023 at 06:13:07PM +0200, Christian Brauner wrote: > Currently, we use a global variable to stash the destination > mountpoint. All global variables are changed in propagate_one(). The > mountpoint variable is one of the few which doesn't change after > initialization. Instead, just pass the destination mountpoint directly > making it easy to verify directly in propagate_mnt() that the > destination mountpoint never changes. > > Signed-off-by: Christian Brauner This doesn't seem to have anything to do with the rest of the series, but it does make the code a little easier to follow. Reviewed-by: Seth Forshee (DigitalOcean)