From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EAB6C76196 for ; Thu, 6 Apr 2023 19:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238022AbjDFTmz (ORCPT ); Thu, 6 Apr 2023 15:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237708AbjDFTmi (ORCPT ); Thu, 6 Apr 2023 15:42:38 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90984A253; Thu, 6 Apr 2023 12:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tmB9ef+i/tR2RuBXG/MztGedwZCTfoIM0/9hlfY16FE=; b=WS2ep4RielBa//Iw2N2zKAwJpB qCW3YjQTQSwAfLWsSVsoutV7+iFjBH0DhQtPhkG887UABmFOFnrdWoBFNHbNrBDGCbea+U+ZLElHR jpnGTSqsWJWh0+w3U9mnzIHezeB6zdA0kAhtzl4zo5p3DWPnrqay+5ChonJviuxlPMDAQG8hMWorV 2CC5n6nWzUM6tnRcyPe/cG3Kv4Sm0Ab2RHPfymfryGeBemgO975S3yOvUByubbHw2gtLGkrDa7AmR Wsm44B7yKULXBY79o00EeBYucQQJa/sJzME5G+YJ/eYZV9hsFkGFwuEa6k6mHoenQ1IYFk4Rdb8AG xKOLOPiw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pkVUg-0006hi-MQ; Thu, 06 Apr 2023 19:42:02 +0000 Date: Thu, 6 Apr 2023 20:42:02 +0100 From: Matthew Wilcox To: Tim Chen Cc: Yosry Ahmed , Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 2/2] mm: vmscan: refactor reclaim_state helpers Message-ID: References: <20230405185427.1246289-1-yosryahmed@google.com> <20230405185427.1246289-3-yosryahmed@google.com> <7ce03e4323b95c1e8fd3faed32c9b285162fe5a8.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ce03e4323b95c1e8fd3faed32c9b285162fe5a8.camel@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 06, 2023 at 10:31:53AM -0700, Tim Chen wrote: > On Wed, 2023-04-05 at 18:54 +0000, Yosry Ahmed wrote: > > + * For all of these cases, we have no way of finding out whether these > > + * pages were related to the memcg under reclaim. For example, a freed > > + * slab page could have had only a single object charged to the memcg > > Minor nits: > s/could have had/could have No ... "could have had" is correct. I'm a native English speaker, so I have no idea what the rule here is, but I can ask my linguist wife later if you want to know ;-) Maybe it's something like this: https://www.englishgrammar.org/have-had-and-had-had/