From: Luis Chamberlain <mcgrof@kernel.org>
To: ye.xingchen@zte.com.cn
Cc: keescook@chromium.org, yzaikin@google.com,
akpm@linux-foundation.org, chi.minghao@zte.com.cn,
linmiaohe@huawei.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V7 1/2] mm: compaction: move compaction sysctl to its own file
Date: Mon, 27 Mar 2023 21:49:12 -0700 [thread overview]
Message-ID: <ZCJxyOX22ZeijBys@bombadil.infradead.org> (raw)
In-Reply-To: <202303281002046981494@zte.com.cn>
On Tue, Mar 28, 2023 at 10:02:04AM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> This moves all compaction sysctls to its own file.
>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Your commit log did not improve as requested sadly. Please look at
the other kernel/sysctl.c changes and you can find much better
motivations documented before there.
For example a467257ffe4 ("kernel/kexec_core: move kexec_core sysctls
into its own file"). You can also now add the defconfig size results
you had mentioned last.
Luis
prev parent reply other threads:[~2023-03-28 4:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 2:02 [PATCH V7 1/2] mm: compaction: move compaction sysctl to its own file ye.xingchen
2023-03-28 4:49 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCJxyOX22ZeijBys@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chi.minghao@zte.com.cn \
--cc=keescook@chromium.org \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).