From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D57BC6FD1D for ; Tue, 4 Apr 2023 15:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235165AbjDDPJY (ORCPT ); Tue, 4 Apr 2023 11:09:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232695AbjDDPJX (ORCPT ); Tue, 4 Apr 2023 11:09:23 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9AE359F; Tue, 4 Apr 2023 08:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PlNwhxmRsqAwivE1o4coXOoSVUnRwZpYbtOW5USkPZw=; b=zpV9QjGDblzOdT3Kpl/izTo0J+ ojzjuO+DWg0aaCeHuCFEMQoNJ1qVxvDWY5z71t5kvNZUV1lQUm4yb5vtR2bIPAKrIb5N1udjGt9Rk gV2W8FHgScYVgfs1W+znbo2NtP/oA7EIwCTNK1BYGfMQaCOzdUCfA5+jPGCodnJLBeZ1Y9HuCMTUZ NhZTqatBJlNvnpwAWTZW17Q41G15Slw/1UFT5OppIWUJUrO0pmhe+8jxbCgUVEIShGHyH4cTdBD/d 9DF5rIAbpmX/6XACqnqm7wsW7ZjKnMHgXsJogBYve1FvXu8wpB0O+0JM4PW2EenYkKVq10vyInIej jfGiLqEg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pjiHd-001wCA-0R; Tue, 04 Apr 2023 15:09:17 +0000 Date: Tue, 4 Apr 2023 08:09:17 -0700 From: Christoph Hellwig To: Pankaj Raghav Cc: axboe@kernel.dk, minchan@kernel.org, martin@omnibond.com, hubcap@omnibond.com, brauner@kernel.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, akpm@linux-foundation.org, willy@infradead.org, hch@lst.de, devel@lists.orangefs.org, mcgrof@kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gost.dev@samsung.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 3/5] mpage: split bi_end_io callback for reads and writes Message-ID: References: <20230403132221.94921-1-p.raghav@samsung.com> <20230403132221.94921-4-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403132221.94921-4-p.raghav@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > struct page *page = bv->bv_page; > - page_endio(page, bio_op(bio), > + page_endio(page, REQ_OP_READ, > + blk_status_to_errno(bio->bi_status)); Nit: I think we can do without the page local variable here. > + bio_for_each_segment_all(bv, bio, iter_all) { > + struct page *page = bv->bv_page; > + page_endio(page, REQ_OP_WRITE, > blk_status_to_errno(bio->bi_status)); Same here. > } > > @@ -59,7 +73,11 @@ static void mpage_end_io(struct bio *bio) > > static struct bio *mpage_bio_submit(struct bio *bio) > { > - bio->bi_end_io = mpage_end_io; > + if (op_is_write(bio_op(bio))) > + bio->bi_end_io = mpage_write_end_io; > + else > + bio->bi_end_io = mpage_read_end_io; > + I'd also split mpage_bio_submit as all allers are clearly either for reads or writes.