From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C68C7619A for ; Tue, 11 Apr 2023 05:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229841AbjDKFio (ORCPT ); Tue, 11 Apr 2023 01:38:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbjDKFin (ORCPT ); Tue, 11 Apr 2023 01:38:43 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DACC26AB; Mon, 10 Apr 2023 22:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wdjx0PzS8xymLv6V2DZoByQwCNONkYBPrVTslqWkC1A=; b=zAusoAFh2XMcpSwwXL3MEkMcu7 Xj1oSdkF/wpKDaVA9/ijVxJ3R2zTgfN5VRSQKn6+CrqM3Eh2Q7X3alR28o/5krCxZEjZYdWzzP0/r YbA+BQ8PdNq1+4l35cH2F6+7F0/Pj6DW/VmUQWXaEKRNupQOUOriwuguaWwZ/2DoIP5Bv4bY6/Ywg qI74eVnfuSSrwCb2pAdbN4PUQftLzlVzNnm4XND4ERebRG1BAMqtsjEn1vEyJuh7BydIjEFAgSExv BfOnzxa9My4ShATNT1ynIG8JWZ8GOSwLNVBxKwLxMVteB3NPIfEoPuYlJikt05r7FymlF/l/aSlus GaSLvs/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pm6iE-00GU6N-2t; Tue, 11 Apr 2023 05:38:38 +0000 Date: Mon, 10 Apr 2023 22:38:38 -0700 From: Christoph Hellwig To: "Ritesh Harjani (IBM)" Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara , Christoph Hellwig , "Darrick J . Wong" , Ojaswin Mujoo Subject: Re: [RFCv2 8/8] ext2: Add direct-io trace points Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Apr 11, 2023 at 10:51:56AM +0530, Ritesh Harjani (IBM) wrote: > This patch adds the trace point to ext2 direct-io apis > in fs/ext2/file.c Wouldn't it make more sense to add this to iomap instead?