From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0166C77B61 for ; Thu, 13 Apr 2023 17:06:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230129AbjDMRGn (ORCPT ); Thu, 13 Apr 2023 13:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbjDMRGl (ORCPT ); Thu, 13 Apr 2023 13:06:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B7DB61B3; Thu, 13 Apr 2023 10:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FWNdRPWwZIBOUH8O1nX0Jh8GOMtO3mkwP8PTJkAEW0Q=; b=LQWB9l7qZaWxf8UflsvmZ+wIIq UF3zLo4TvW35Q5imqsrf3yqsQT6EqtmrxoSu/XHuAvekpk/IKCOklrUWVJRmElAkIZseIeJVtwEkf gKr5eBelaUAzJvqFS9tmxlEQ77Byc91505FskaWdCiol7I/eyhoBTejMEcvw0MYC/Q05dT/zfb7Dd lMjrBOzEV7rvUuUttb/2X/coWbS3PK0L6aUQ7JW3M7gjOJ+718WBlwEfTr/zss0xLsbsJ0kuNiiD3 hiqjY7imMX4a0ul0JBKyMRYWgm9+AoGuwENm9iiAmaSqMRS16tdwkXrFZpvOJMlqSH9fGzkgPPW4g OLHgUD7Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pn0P5-006lZO-28; Thu, 13 Apr 2023 17:06:35 +0000 Date: Thu, 13 Apr 2023 10:06:35 -0700 From: Luis Chamberlain To: Christian Brauner Cc: Kefeng Wang , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-kernel@vger.kernel.org, Alexander Viro Subject: Re: [PATCH] fs: fix sysctls.c built Message-ID: References: <20230331084502.155284-1-wangkefeng.wang@huawei.com> <66c0e8b6-64d1-5be6-cd4d-9700d84e1b84@huawei.com> <20230412-sympathie-haltbar-da2d2183067b@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412-sympathie-haltbar-da2d2183067b@brauner> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 12, 2023 at 11:19:56AM +0200, Christian Brauner wrote: > On Tue, Apr 11, 2023 at 12:14:44PM +0800, Kefeng Wang wrote: > > /proc/sys/fs/overflowuid and overflowgid will be lost without > > building this file, kindly ping, any comments, thanks. > > > > > > On 2023/3/31 16:45, Kefeng Wang wrote: > > > 'obj-$(CONFIG_SYSCTL) += sysctls.o' must be moved after "obj-y :=", > > > or it won't be built as it is overwrited. > > > > > > Fixes: ab171b952c6e ("fs: move namespace sysctls and declare fs base directory") > > > Signed-off-by: Kefeng Wang > > > --- > > > fs/Makefile | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/fs/Makefile b/fs/Makefile > > > index 05f89b5c962f..8d4736fcc766 100644 > > > --- a/fs/Makefile > > > +++ b/fs/Makefile > > > @@ -6,7 +6,6 @@ > > > # Rewritten to use lists instead of if-statements. > > > # > > > -obj-$(CONFIG_SYSCTL) += sysctls.o > > > obj-y := open.o read_write.o file_table.o super.o \ > > > char_dev.o stat.o exec.o pipe.o namei.o fcntl.o \ > > > @@ -50,7 +49,7 @@ obj-$(CONFIG_FS_MBCACHE) += mbcache.o > > > obj-$(CONFIG_FS_POSIX_ACL) += posix_acl.o > > > obj-$(CONFIG_NFS_COMMON) += nfs_common/ > > > obj-$(CONFIG_COREDUMP) += coredump.o > > > -obj-$(CONFIG_SYSCTL) += drop_caches.o > > > +obj-$(CONFIG_SYSCTL) += drop_caches.o sysctls.o > > > obj-$(CONFIG_FHANDLE) += fhandle.o > > > obj-y += iomap/ > > Given the description in > ab171b952c6e ("fs: move namespace sysctls and declare fs base directory") > you probably want to move this earlier. I was being *way* too cautious and I was wrong, so I'll take Kefang's patch as I can verify now that order does not matter and his patch is correct. I've corrected the documentation and clarified this on sysctl-next and so reflected on linux-next too with these two patches: sysctl: clarify register_sysctl_init() base directory order https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?h=sysctl-next-20230413&id=8ae59580f2b0529b6dd1a1cda6b838cfb268cb87 proc_sysctl: move helper which creates required subdirectories https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?h=sysctl-next-20230413&id=f4c09b14073513efd581459520a01c4c88cb24d7 proc_sysctl: update docs for __register_sysctl_table() https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?h=sysctl-next-20230413&id=d59d91edd67ec4cef62f26249510fe08b291ae72 proc_sysctl: enhance documentation https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?h=sysctl-next-20230413&id=eb472aa0678fd03321093bffeb9c7fd7f5035844 And so something we can do eventually is do away with all the base stuff. For now it's fine, it's not creating an issue. Luis