From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1540CC7EE2E for ; Tue, 9 May 2023 16:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234489AbjEIQw3 (ORCPT ); Tue, 9 May 2023 12:52:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234356AbjEIQw0 (ORCPT ); Tue, 9 May 2023 12:52:26 -0400 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8F21732 for ; Tue, 9 May 2023 09:51:41 -0700 (PDT) Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-75131c2997bso2273267185a.1 for ; Tue, 09 May 2023 09:51:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683651101; x=1686243101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8AiXugarlhHToBN2ueOGwWaX5E4llz8s13EASoB3wVI=; b=I8YdbRlVuGbwWBb/59zf/o4dS6Oz0wMfai4aHROkbo9Bwf7v3CyYIUlmTojenkwf9b Sj/QDMSYSofvKV9kw30DwMDtsfnjhHusnSXPh4nNS5kTJcxv7J05IHb8DnifJOVl/fek im1yLMYYtI6v2x922S9Ao73rQeSTioWvP2RDgXr0OIZ+XOrothJk6k9PQLLyZrK50x2l Y8iIVTI2RUZs/vyDgrpl9tQ02lyJTeySeaQvxjjGc2gxyAij2R0Hx4+KWSk849ygv1Yw 2B92mPrLuIinH91BidAHuX4IhfvfydlYZQ8JZYYB+5Ui9G6q/Lb0jmkNcfG7gl/PkOXA Getg== X-Gm-Message-State: AC+VfDx6nuCbvMeX4p3gxmlJA7BTG+uaM4FKnl8hzlO2VGpE8alreWh4 TlkqA3BlvBSh/rULr2ll6enJ X-Google-Smtp-Source: ACHHUZ4xRyujKImbkSQcW8Z759B/taKjk2/BBWT+4ePbKXa9irKnpFPNPIQc/SyDOhMLc66FmfxRwA== X-Received: by 2002:a05:6214:29c7:b0:56e:c066:3cd2 with SMTP id gh7-20020a05621429c700b0056ec0663cd2mr19939922qvb.2.1683651100740; Tue, 09 May 2023 09:51:40 -0700 (PDT) Received: from localhost ([217.138.208.150]) by smtp.gmail.com with ESMTPSA id m4-20020a0cf184000000b0061b3338d6d9sm890247qvl.50.2023.05.09.09.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 09:51:40 -0700 (PDT) Date: Tue, 9 May 2023 12:51:38 -0400 From: Mike Snitzer To: Sarthak Kukreti Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Theodore Ts'o , "Michael S. Tsirkin" , "Darrick J. Wong" , Jason Wang , Bart Van Assche , stable@vger.kernel.org, Christoph Hellwig , Andreas Dilger , Stefan Hajnoczi , Brian Foster , Alasdair Kergon Subject: Re: [PATCH v6 1/5] block: Don't invalidate pagecache for invalid falloc modes Message-ID: References: <20230420004850.297045-1-sarthakkukreti@chromium.org> <20230506062909.74601-1-sarthakkukreti@chromium.org> <20230506062909.74601-2-sarthakkukreti@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230506062909.74601-2-sarthakkukreti@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, May 06 2023 at 2:29P -0400, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") > Cc: stable@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti Reviewed-by: Mike Snitzer