From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C24C77B75 for ; Tue, 9 May 2023 20:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbjEIUP2 (ORCPT ); Tue, 9 May 2023 16:15:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbjEIUP1 (ORCPT ); Tue, 9 May 2023 16:15:27 -0400 Received: from out-42.mta0.migadu.com (out-42.mta0.migadu.com [91.218.175.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FE7910F6 for ; Tue, 9 May 2023 13:15:26 -0700 (PDT) Date: Tue, 9 May 2023 16:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1683663324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LkTznK2Z03Vodu7CHSj8IilAg1DvNfs35ZJK4M95LHM=; b=hVlZyijC8g1SgMMcQzMD2aPZOFsIXJukaHMQb7xAEZD0ie3kpmD214xSLxW6Qwe29rRInp iGi16+pUQ1aKH0le1y5M7fozdDuuDjk5weFK4WsJ2563X4AR/tPsnXme6t3R11oOvUVdxp 0emtidDzOsxOH1uEW0xSB7wFOIfH52M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Kent Overstreet , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, May 09, 2023 at 11:19:38AM -0700, Lorenzo Stoakes wrote: > On Tue, May 09, 2023 at 12:56:32PM -0400, Kent Overstreet wrote: > > From: Kent Overstreet > > > > This is needed for bcachefs, which dynamically generates per-btree node > > unpack functions. > > Small nits - > > Would be good to refer to the original patch that removed it, > i.e. 7a0e27b2a0ce ("mm: remove vmalloc_exec") something like 'patch > ... folded vmalloc_exec() into its one user, however bcachefs requires this > as well so revert'. > > Would also be good to mention that you are now exporting the function which > the original didn't appear to do. > > > > > Signed-off-by: Kent Overstreet > > Cc: Andrew Morton > > Cc: Uladzislau Rezki > > Cc: Christoph Hellwig > > Cc: linux-mm@kvack.org > > Another nit: I'm a vmalloc reviewer so would be good to get cc'd too :) > (forgivable mistake as very recent change!) Thanks - folded your suggestions into the commit message, and added you for the next posting :)