From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 296B5C77B7E for ; Thu, 25 May 2023 23:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233538AbjEYXFb (ORCPT ); Thu, 25 May 2023 19:05:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbjEYXFa (ORCPT ); Thu, 25 May 2023 19:05:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53223E2; Thu, 25 May 2023 16:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1wIWSmx8tL1zwRosKN785Bsjw/NXry+bXUPs1s1BkGA=; b=nYujE/Ekj6U8L08bVcRYWqNpVi gjNO473kYesKbi1pg4x7EzWo9m2GVJnkq0OKJBo8LAe6OvS5M2BgJEZRZu8Xl3HzPcwKet+nEgyoS rxXJxPJVrgjuoXta18NBLgspC+r1WrkTjeqpeqkh9nz5ws02AhB5trWOTKBqHJKyDuo3UzcuCob3h DHUVEwmrG7yeX7J00INUlganD9IUMQgcblHaTzkX9+1Tip1NCfXR9ZkxO5CMNtSbn9wY3gh7UyAk/ /3D0s6NQU32BfbUKM0qkGhhD17VwGf0OJruB6cRTmWPTIhWPoEcpRVMUeps4bWMJVOK8S+GlWb9E1 c5KM9IbQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q2K0m-000Mm9-0S; Thu, 25 May 2023 23:04:48 +0000 Date: Thu, 25 May 2023 16:04:48 -0700 From: Luis Chamberlain To: Dave Hansen Cc: keescook@chromium.org, yzaikin@google.com, ebiederm@xmission.com, arnd@arndb.de, bp@alien8.de, James.Bottomley@hansenpartnership.com, deller@gmx.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, christophe.jaillet@wanadoo.fr, kirill.shutemov@linux.intel.com, jroedel@suse.de, j.granados@samsung.com, akpm@linux-foundation.org, willy@infradead.org, linux-parisc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] signal: move show_unhandled_signals sysctl to its own file Message-ID: References: <20230522210814.1919325-1-mcgrof@kernel.org> <20230522210814.1919325-3-mcgrof@kernel.org> <603f5357-3018-6c1b-2dc8-ec96aee9552c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <603f5357-3018-6c1b-2dc8-ec96aee9552c@intel.com> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, May 25, 2023 at 11:52:58AM -0700, Dave Hansen wrote: > On 5/24/23 00:30, Luis Chamberlain wrote: > >> It doesn't actually have anything to do with moving the > >> show_unhandled_signals sysctl, right? > > Well in my case it is making sure the sysctl variable used is declared > > as well. > > But what does this have to do with _this_ patch? This: Because to create consistency for the users. > > --- a/arch/x86/kernel/umip.c > > +++ b/arch/x86/kernel/umip.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > For instance. You don't move things to another header or make *ANY* > change to the compilation of umip.c. So why patch it? > > It looks to me like a _fundamentally_ superfluous change. That hunk > literally *can't* be related to the rest of the patch. I suspect it is not needed as otherwise compilation would have failed. So I'll just drop it. > >> If that's the case, it would be nice to have this in its own patch. > > If its not really fixing any build bugs or functional bugs I don't see > > the need. But if you really want it, I can do it. > > > > Let me know! > > Yes, I really want it. > > Please remove all the x86 bits from _this_ patch. If x86 has a > separate, preexisting problem, please send that patch separately with a > separate changelog and justification. > > We'll take a look. Sounds good. Luis