From: Luis Chamberlain <mcgrof@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
hch@lst.de, brauner@kernel.org, david@redhat.com
Cc: tglx@linutronix.de, patches@lists.linux.dev,
linux-modules@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, pmladek@suse.com,
petr.pavlu@suse.com, prarit@redhat.com, lennart@poettering.net,
gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org,
lucas.de.marchi@gmail.com, lucas.demarchi@intel.com,
christophe.leroy@csgroup.eu, peterz@infradead.org,
rppt@kernel.org, dave@stgolabs.net, willy@infradead.org,
vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com,
colin.i.king@gmail.com, jim.cromie@gmail.com,
catalin.marinas@arm.com, jbaron@akamai.com,
rick.p.edgecombe@intel.com, yujie.liu@intel.com
Subject: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection
Date: Thu, 25 May 2023 11:35:13 -0700 [thread overview]
Message-ID: <ZG+qYdGsbE7mOn6M@bombadil.infradead.org> (raw)
In-Reply-To: <ZG+kDevFH6uE1I/j@bombadil.infradead.org>
On Thu, May 25, 2023 at 11:08:13AM -0700, Luis Chamberlain wrote:
> + fsdevel please review,
> So with two other hunks added (2nd and 4th), this now matches parity with
> my patch, not suggesting this is right, just demonstrating how this
> could be resolved with this. We could also just have a helper which lets
> the module code allow_write_access() at the end of its use of the fd
> (failure to load or module is removed).
This even fixes the pathological case with stress-ng for finit_module:
./stress-ng --module 8192 --module-name xfs
(stress-ng assumes you have all dependencies already loaded and
the module is not loaded, it uses finit_module() directly)
Luis
next prev parent reply other threads:[~2023-05-25 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230524213620.3509138-1-mcgrof@kernel.org>
[not found] ` <20230524213620.3509138-2-mcgrof@kernel.org>
[not found] ` <CAHk-=wjahcAqLYm0ijcAVcPcQAz-UUuJ3Ubx4GzP_SJAupf=qQ@mail.gmail.com>
2023-05-25 7:01 ` [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection Christian Brauner
[not found] ` <CAHk-=wgKu=tJf1bm_dtme4Hde4zTB=_7EdgR8avsDRK4_jD+uA@mail.gmail.com>
2023-05-25 18:08 ` Luis Chamberlain
2023-05-25 18:35 ` Luis Chamberlain [this message]
2023-05-25 18:50 ` Linus Torvalds
2023-05-25 19:32 ` Luis Chamberlain
[not found] ` <20230524213620.3509138-3-mcgrof@kernel.org>
[not found] ` <8fc5b26b-d2f6-0c8f-34a1-af085dbef155@suse.com>
[not found] ` <CAHk-=wiPjcPL_50WRWOi-Fmi9TYO6yp_oj63a_N84FzG-rxGKQ@mail.gmail.com>
[not found] ` <2023052518-unable-mortician-4365@gregkh>
2023-05-25 18:22 ` [PATCH 2/2] module: add support to avoid duplicates early on load Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG+qYdGsbE7mOn6M@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=brauner@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=colin.i.king@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=lennart@poettering.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
--cc=mhocko@suse.com \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=rafael@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).