From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A48BC77B73 for ; Wed, 24 May 2023 07:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239899AbjEXHb2 (ORCPT ); Wed, 24 May 2023 03:31:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233663AbjEXHb1 (ORCPT ); Wed, 24 May 2023 03:31:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5401790; Wed, 24 May 2023 00:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JWeiXDNejpnwIzLgTU/23od5O2F3Mmup/rXfS/mSgtU=; b=RbsSpdIBOq3BZKkwPoSgqQayF2 5P6+wfsjWDMtGKARnHgBscWBdI8H4uGcbVNEo5jf55w6njt21XXGOl1hcJObLAH3zJyCra5OVogsl O41eYrcAYVeOwCzfqRIYnzPZHnh8uc0UYebhT5ua3goSwQL5KDfCwZ+4X+acQHOCb356auBFyjgE0 o3GsrgFTDP6HjbXxYfQgQCv4HzTpKMcv6HJvEPDjpWEv8hLSTmVuXqF4nQMi86BejMVFA1r0xnOcF x1bEoniUEKfRuEBN/s7ldzV1qSMGHIdD2gvX/mr74+AebCG4APyA8vzfL+WNt8UJH7hQmkD8RZnoJ tE0ldKYA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1ixB-00CcAF-0o; Wed, 24 May 2023 07:30:37 +0000 Date: Wed, 24 May 2023 00:30:37 -0700 From: Luis Chamberlain To: Dave Hansen Cc: keescook@chromium.org, yzaikin@google.com, ebiederm@xmission.com, arnd@arndb.de, bp@alien8.de, James.Bottomley@hansenpartnership.com, deller@gmx.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, christophe.jaillet@wanadoo.fr, kirill.shutemov@linux.intel.com, jroedel@suse.de, j.granados@samsung.com, akpm@linux-foundation.org, willy@infradead.org, linux-parisc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] signal: move show_unhandled_signals sysctl to its own file Message-ID: References: <20230522210814.1919325-1-mcgrof@kernel.org> <20230522210814.1919325-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, May 23, 2023 at 07:16:55AM -0700, Dave Hansen wrote: > On 5/22/23 14:08, Luis Chamberlain wrote: > > --- a/arch/x86/kernel/umip.c > > +++ b/arch/x86/kernel/umip.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > Oh, so this is actually fixing a bug: umip.c uses > 'show_unhandled_signals' but it doesn't explicitly include > linux/signal.h where 'show_unhandled_signals' is declared. Fixes a non-critical bug perhaps, but I doubt it would be fixing a functional bug as otherwise folks would have reported a build bug, no? What or how it ends up including that file today to avoid build failures is beyond me. > It doesn't actually have anything to do with moving the > show_unhandled_signals sysctl, right? Well in my case it is making sure the sysctl variable used is declared as well. > If that's the case, it would be nice to have this in its own patch. If its not really fixing any build bugs or functional bugs I don't see the need. But if you really want it, I can do it. Let me know! Luis