From: Luis Chamberlain <mcgrof@kernel.org>
To: Joel Granados <j.granados@samsung.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Iurii Zaikin <yzaikin@google.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/6] sysctl: Remove register_sysctl_table from parport
Date: Mon, 15 May 2023 13:24:06 -0700 [thread overview]
Message-ID: <ZGKU5vP8Anmfeen0@bombadil.infradead.org> (raw)
In-Reply-To: <20230515071446.2277292-1-j.granados@samsung.com>
On Mon, May 15, 2023 at 09:14:40AM +0200, Joel Granados wrote:
> This is part of the general push to deprecate register_sysctl_paths and
> register_sysctl_table. Parport driver uses the "CHILD" pointer
> in the ctl_table structure to create its directory structure. We move to
> the newer register_sysctl call and remove the pointer madness.
Nice! Thanks for doing this and unwinding the sysctl use case which
takes the cake for the obfuscation use case of sysctls.
> I have separated the parport into 5 patches to clarify the different
> changes needed for the 3 calls to register_sysctl_paths. I can squash
> them together if need be.
I think it makes sense to keep them that way.
> We no longer export the register_sysctl_table call as parport was the
> last user from outside proc_sysctl.c. Also modified documentation slightly
> so register_sysctl_table is no longer mentioned.
We can go further, but I'll explain in patch review on the patches.
> I'm waiting on the 0-day tests results.
Nice!
Luis
next prev parent reply other threads:[~2023-05-15 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230515071448eucas1p111c55b7078f1541f487c9dfb1a9f9c15@eucas1p1.samsung.com>
2023-05-15 7:14 ` [PATCH 0/6] sysctl: Remove register_sysctl_table from parport Joel Granados
[not found] ` <CGME20230515071449eucas1p172217753f35fed55c4d2f0a419e258dd@eucas1p1.samsung.com>
2023-05-15 7:14 ` [PATCH 1/6] parport: Move magic number "15" to a define Joel Granados
[not found] ` <CGME20230515071450eucas1p1625a8639e2b0edf47e41126801d4cbb8@eucas1p1.samsung.com>
2023-05-15 7:14 ` [PATCH 2/6] parport: Remove register_sysctl_table from parport_proc_register Joel Granados
2023-05-16 4:17 ` Luis Chamberlain
2023-05-16 14:31 ` Joel Granados
2023-05-16 16:12 ` Joel Granados
2023-05-16 21:49 ` Luis Chamberlain
[not found] ` <CGME20230515071452eucas1p1d535f6636b45c193b6b24fa59ff100a6@eucas1p1.samsung.com>
2023-05-15 7:14 ` [PATCH 3/6] parport: Remove register_sysctl_table from parport_device_proc_register Joel Granados
[not found] ` <CGME20230515192630eucas1p2c9bf0ffa8ddc2d0bcf9a9818c6ecd6a8@eucas1p2.samsung.com>
2023-05-15 19:10 ` Joel Granados
[not found] ` <CGME20230515071454eucas1p2ae422c4bad233cd6170dce9e7f8304d9@eucas1p2.samsung.com>
2023-05-15 7:14 ` [PATCH 4/6] parport: Remove register_sysctl_table from parport_default_proc_register Joel Granados
[not found] ` <CGME20230515071456eucas1p1e92a011498b7f3ca2e02cdc8f0d39415@eucas1p1.samsung.com>
2023-05-15 7:14 ` [PATCH 5/6] parport: Removed sysctl related defines Joel Granados
[not found] ` <CGME20230515071457eucas1p105a2dba9f4741cd6fe495bcf527d664d@eucas1p1.samsung.com>
2023-05-15 7:14 ` [PATCH 6/6] sysctl: stop exporting register_sysctl_table Joel Granados
2023-05-15 20:24 ` Luis Chamberlain [this message]
2023-05-16 14:06 ` [PATCH 0/6] sysctl: Remove register_sysctl_table from parport Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGKU5vP8Anmfeen0@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=j.granados@samsung.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).