From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D5AC77B7D for ; Mon, 15 May 2023 20:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245192AbjEOUYU (ORCPT ); Mon, 15 May 2023 16:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245150AbjEOUYT (ORCPT ); Mon, 15 May 2023 16:24:19 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E8FB10CE; Mon, 15 May 2023 13:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y8GfYxEehE3KNcEtHln0pLTgiDjTpLWN9Yvcq3hlIwc=; b=35620JKfdubiAZiQIWGRjKhamW yU7sN2mTXJJVzsqBgieI9wOkm3kBUrb03E6xEThFvXfIy0+1Ypk+oAY8fnlJ+cVP3Ae7S0A8bOshK MHZ/akWZL0F+/82Ova+HVLa2At7FhTihItrQIlJDGaCwHv68CB1fr+i4BOHWTddCtLceEJIg5Ydgm w+pAwaLkOWBijEaAoFMm6ZIt4Zto1EOAcTeP7b1UMAxX4GQe2ZnrnvtGS+WS8dPZ7VSmxV0TQvgSJ tZUBN73YQ+ILsWpkFmlOr0Gpc0h8L6kLN6PiBqOvQ7H3h6EClSSC57Q+cyipit0StJ0vxKuI0hB/c BFO4CBqg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pyejm-003QNT-0Z; Mon, 15 May 2023 20:24:06 +0000 Date: Mon, 15 May 2023 13:24:06 -0700 From: Luis Chamberlain To: Joel Granados Cc: Sudip Mukherjee , Iurii Zaikin , Kees Cook , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/6] sysctl: Remove register_sysctl_table from parport Message-ID: References: <20230515071446.2277292-1-j.granados@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515071446.2277292-1-j.granados@samsung.com> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, May 15, 2023 at 09:14:40AM +0200, Joel Granados wrote: > This is part of the general push to deprecate register_sysctl_paths and > register_sysctl_table. Parport driver uses the "CHILD" pointer > in the ctl_table structure to create its directory structure. We move to > the newer register_sysctl call and remove the pointer madness. Nice! Thanks for doing this and unwinding the sysctl use case which takes the cake for the obfuscation use case of sysctls. > I have separated the parport into 5 patches to clarify the different > changes needed for the 3 calls to register_sysctl_paths. I can squash > them together if need be. I think it makes sense to keep them that way. > We no longer export the register_sysctl_table call as parport was the > last user from outside proc_sysctl.c. Also modified documentation slightly > so register_sysctl_table is no longer mentioned. We can go further, but I'll explain in patch review on the patches. > I'm waiting on the 0-day tests results. Nice! Luis