From: Luis Chamberlain <mcgrof@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: corbet@lwn.net, jake@lwn.net, hch@infradead.org,
djwong@kernel.org, dchinner@redhat.com, ritesh.list@gmail.com,
rgoldwyn@suse.com, jack@suse.cz, linux-doc@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, p.raghav@samsung.com,
da.gomez@samsung.com, rohan.puri@samsung.com
Subject: Re: [PATCH v2] Documentation: add initial iomap kdoc
Date: Thu, 18 May 2023 13:55:48 -0700 [thread overview]
Message-ID: <ZGaQ1KzKGuuPIpTb@bombadil.infradead.org> (raw)
In-Reply-To: <707b28de-2449-5cf3-9360-b2faec0481c7@infradead.org>
On Thu, May 18, 2023 at 08:49:26AM -0700, Randy Dunlap wrote:
> On 5/18/23 08:01, Luis Chamberlain wrote:
> > * use 80 char length as if we're in the 1980's
>
> Well, like Jon said, long lines are difficult to read, even on printed paper.
> That's (at least one reason) why newspapers(!) have narrow columns of print.
Makes sense!
> Anyway, thanks for doing it.
Heh yeah, I just trying to follow the convention, but I didn't know it was
a special-case for bumping up to 100 only, and that it was definitely
not good for docs. It's easy to loose it though, we have one for commit log,
one for length on code with an exception, and we have a clear perference
for docs. Makes me wonder if editors pick up on project specific requirements
somehow?
So for instance I used to have incorrectly;
set textwidth=100
autocmd FileType gitcommit set textwidth=72
set colorcolumn=+1
Cleary that 100 is wrong now and I've now updated it bacak to 80.
Could one be used for FileType for rst and ascii files?
If we shared something on the top level which lets developers
optionally pick up on project specific guideline it would be a less
common problem to ping back / forth about this. Curious how many
patches "length" is the reason introduces a latency for patches getting
upstream. You figured this would be a simple fix in year 2023 :P
Thanks for the fix recommendations! I'll wait and see if others find
others!
Luis
next prev parent reply other threads:[~2023-05-18 20:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 15:01 [PATCH v2] Documentation: add initial iomap kdoc Luis Chamberlain
2023-05-18 15:49 ` Randy Dunlap
2023-05-18 20:55 ` Luis Chamberlain [this message]
2023-05-18 20:15 ` kernel test robot
2023-05-18 20:38 ` kernel test robot
2023-05-18 23:09 ` Jonathan Corbet
2023-05-19 1:48 ` Dave Chinner
2023-05-19 12:41 ` Jonathan Corbet
2023-05-19 5:04 ` Christoph Hellwig
2023-05-23 1:20 ` Darrick J. Wong
2023-05-23 2:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGaQ1KzKGuuPIpTb@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=corbet@lwn.net \
--cc=da.gomez@samsung.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jake@lwn.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=rdunlap@infradead.org \
--cc=rgoldwyn@suse.com \
--cc=ritesh.list@gmail.com \
--cc=rohan.puri@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).