From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DEAEC7EE29 for ; Sat, 20 May 2023 04:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbjETENx (ORCPT ); Sat, 20 May 2023 00:13:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbjETENw (ORCPT ); Sat, 20 May 2023 00:13:52 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C341E46; Fri, 19 May 2023 21:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xi4OUwMjj6B5meDIABpjuRK4Kr+q2y1yEM0f2xLNo2w=; b=w3ZGmsdU8hhe/7c+F8CRKXYNfw HhUo290wLcW0X+8ICvnQxtdMgPwpdGPH94AWRSZbCcEYiunEnXAdq8yIO71PNcxyf2aM2I4h07E/Y n1z9k6gW52OG/wtRTNmIm3iHqjvM10Y4XqmuF93RrnWf2IFKfJUWRj8NCzgAsSCmKEcyQD/AiFsbj K4l07RhpT3hk2C8/G89ne1NO2mAlvTK7bWPHFGMwnLzM8MA00YNd0XVAFOJ/HRb6GHIBjboyNCZJ8 gMrpPzrylB7vG3yRmmKvsL507SXFpiYJy4pmPl/OWzpWgIDmEQhhi3b+j1hoqDmATrLPuWc0Tlaiw lQzoY4rA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0DyQ-000dg9-0X; Sat, 20 May 2023 04:13:42 +0000 Date: Fri, 19 May 2023 21:13:42 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH v21 24/30] xfs: Provide a splice-read stub Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-25-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-25-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Same comment about stub sounding a bit weird as for ext4 and various patches not in my area, but the changes themselves looks good: Reviewed-by: Christoph Hellwig