From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F30C77B7D for ; Sat, 20 May 2023 04:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbjETELY (ORCPT ); Sat, 20 May 2023 00:11:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbjETELW (ORCPT ); Sat, 20 May 2023 00:11:22 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB7FF1BD; Fri, 19 May 2023 21:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=Pt+PQf6v4zSblP55GrOTDhqctX Mp+y8puOTxwgbvkh7yzi1Zxb6L8eqHWgOmYIBki8oDPw15gwj5EZb9c65zH+dlVlCZsH1VD26uc++ 74cwKZW/BY2tuoIklce27ktMnMX5BxQt+a383yYp98C2Czps/vEC9j7q3RypCqBy8KidJp61DwbED M5iG5GV+kwcuUjYl+78htXNTchWV8SOynSeNQNAS2ttnxFtx3rG6PG+IIJXONB8yg+qtLDL/bjgi+ MlIOl0NJdXEkCANBg4WFNPIs32TnoVar+smRiyVs2irvReXw7RqLKpI85m38mf6Mk3FOte47LIBx0 4sSz2vyQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dvz-000dLD-12; Sat, 20 May 2023 04:11:11 +0000 Date: Fri, 19 May 2023 21:11:11 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v21 07/30] splice: Make splice from an O_DIRECT fd use copy_splice_read() Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-8-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-8-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig