From: Matthew Wilcox <willy@infradead.org>
To: Wang Yugui <wangyugui@e16-tech.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Creating large folios in iomap buffered write path
Date: Sat, 20 May 2023 17:35:52 +0100 [thread overview]
Message-ID: <ZGj26E4rD52Qfe10@casper.infradead.org> (raw)
In-Reply-To: <20230520213531.38CB.409509F4@e16-tech.com>
On Sat, May 20, 2023 at 09:35:32PM +0800, Wang Yugui wrote:
> test result of the second version of the patch.
>
> # dmesg |grep 'index\|suppressed'
> [ 89.376149] index:0 len:292 order:2
> [ 97.862938] index:0 len:4096 order:2
> [ 98.340665] index:0 len:4096 order:2
> [ 98.346633] index:0 len:4096 order:2
> [ 98.352323] index:0 len:4096 order:2
> [ 98.359952] index:0 len:4096 order:2
> [ 98.364015] index:3 len:4096 order:2
> [ 98.368943] index:0 len:4096 order:2
> [ 98.374285] index:0 len:4096 order:2
> [ 98.379163] index:3 len:4096 order:2
> [ 98.384760] index:0 len:4096 order:2
> [ 181.103751] iomap_get_folio: 342 callbacks suppressed
> [ 181.103761] index:0 len:292 order:2
Thanks. Clearly we're not creating large folios in the write path.
I tracked it down, and used your fio command. My system creates 1MB
folios, so I think yours will too. Patch series incoming (I fixed a
couple of other oversights too).
prev parent reply other threads:[~2023-05-20 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230510165055.01D5.409509F4@e16-tech.com>
[not found] ` <20230511013410.GY3223426@dread.disaster.area>
[not found] ` <20230517210740.6464.409509F4@e16-tech.com>
2023-05-18 18:36 ` Creating large folios in iomap buffered write path Matthew Wilcox
2023-05-18 21:46 ` Matthew Wilcox
2023-05-18 22:03 ` Matthew Wilcox
2023-05-19 2:55 ` Wang Yugui
2023-05-19 15:38 ` Matthew Wilcox
2023-05-20 13:35 ` Wang Yugui
2023-05-20 16:35 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGj26E4rD52Qfe10@casper.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).